GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-158529: Prevent mimalloc calling system calls directly on Android by mhsmith · Pull Request #158530 · python/cpython

Conversation

mhsmith commented Sep 30, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Closes mimalloc crashes on Android x86_64, API levels 27-28 #158529

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Prevent mimalloc calling system calls directly on Android

b8cd4aa

mhsmith added OS-android needs backport to 3.14

bugs and security fixes

needs backport to 3.15 bugs and security fixes labels

Sep 30, 2026

bedevere-app Bot mentioned this pull request

Sep 30, 2026

mimalloc crashes on Android x86_64, API levels 27-28 #158529

Closed

bedevere-app Bot added the awaiting review label

Sep 30, 2026


          Add news

51ba641

mhsmith requested a review from ZeroIntensity

September 30, 2026 20:35

freakboy3742 requested changes

Sep 30, 2026

View reviewed changes

freakboy3742 left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself makes sense. However, mimalloc is vendored code; my understanding is that any changes we make here should be reflected (and accepted) as patches upstream as well, or else they'll get lost if/when mimalloc sources are bumped.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot removed the awaiting review label

Sep 30, 2026

bedevere-app Bot commented Sep 30, 2026

Copy link

Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot added the awaiting changes label

Sep 30, 2026

StanFromIreland commented Oct 1, 2026

Copy link

Copy Markdown

Member

However, mimalloc is vendored code; my understanding is that any changes we make here should be reflected (and accepted) as patches upstream as well, or else they'll get lost if/when mimalloc sources are bumped.

They're currently tracked at #113141, I presume a comment there should be fine.

mhsmith and daanx reacted with thumbs up emoji

All reactions

👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

daanx added a commit to microsoft/mimalloc that referenced this pull request

Oct 8, 2026


          prevent syscalls on Android, upstream of python/cpython#158530 (and p…

aef8faa

…ython/cpython#113141)

mhsmith mentioned this pull request

Nov 9, 2026

Mimalloc differences from upstream #113141

Open


          Merge remote-tracking branch 'origin/main' into android-mimalloc-syscall

3f38dfc

mhsmith commented Nov 9, 2026

Copy link

Copy Markdown

Member Author

Thanks to @daanx, this has now been merged and released upstream (microsoft/mimalloc@aef8faa). I've added it to the list in #113141 for future reference.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mhsmith removed the awaiting changes label

Nov 9, 2026

mhsmith enabled auto-merge (squash)

November 9, 2026 21:39

mhsmith merged commit 78407da into python:main

Nov 9, 2026

58 checks passed

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot commented Nov 9, 2026

Copy link

Copy Markdown

Thanks @mhsmith for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot commented Nov 9, 2026

Copy link

Copy Markdown

GH-161709 is a backport of this pull request to the 3.15 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label

Nov 9, 2026

bedevere-app Bot commented Nov 9, 2026

Copy link

Copy Markdown

GH-161710 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label

Nov 9, 2026

mhsmith added a commit that referenced this pull request

Nov 9, 2026


          [3.14] gh-158529: Prevent mimalloc calling system calls directly on A…

5810a10

…ndroid (GH-158530) (#161710)

(cherry picked from commit 78407da)

Co-authored-by: Malcolm Smith <[email protected]>

mhsmith added a commit that referenced this pull request

Nov 9, 2026


          [3.15] gh-158529: Prevent mimalloc calling system calls directly on A…

04cfecc

…ndroid (GH-158530) (#161709)

(cherry picked from commit 78407da)

Co-authored-by: Malcolm Smith <[email protected]>

orsenthil pushed a commit to orsenthil/cpython that referenced this pull request

Nov 12, 2026


          pythongh-158529: Prevent mimalloc calling system calls directly on An…

7889f11

…droid (python#158530)

Reviewers

freakboy3742

freakboy3742 requested changes

ZeroIntensity

Awaiting requested review from ZeroIntensity

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

OS-android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

mimalloc crashes on Android x86_64, API levels 27-28

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

mhsmith commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

freakboy3742 left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-app Bot commented Sep 30, 2026

Uh oh!

StanFromIreland commented Oct 1, 2026

Uh oh!

mhsmith commented Nov 9, 2026

Uh oh!

Uh oh!

miss-islington-app Bot commented Nov 9, 2026

Uh oh!

bedevere-app Bot commented Nov 9, 2026

Uh oh!

bedevere-app Bot commented Nov 9, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mhsmith commented Sep 30, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.