GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-158810: Use _Py_TYPEOF in Py_ARRAY_LENGTH() by vstinner · Pull Request #158838 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Oct 5, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fix the compiler warning "extension used" when building test_cext with clang.

  • test_cext no longer overrides the CC environment variable if it's already defined.
  • test_cext now also logs __STRICT_ANSI__ macro.
  • Issue: [C API] Py_ARRAY_LENGTH() macro is incompatible with g++ -std=gnu++11 #158810

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-158810: Use _Py_TYPEOF in Py_ARRAY_LENGTH()
c1adc06 
Fix the compiler warning "extension used" when building test_cext
with clang.

* test_cext no longer overrides the CC environment variable if it's
  already defined.
* test_cext now also logs __STRICT_ANSI__ macro.
@vstinner vstinner added the skip news label Oct 5, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Oct 5, 2026
[C API] Py_ARRAY_LENGTH() macro is incompatible with g++ -std=gnu++11 #158810
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 5, 2026
@vstinner

vstinner commented Oct 5, 2026

Copy link
Copy Markdown
Member Author

!buildbot ARM64 macOS PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Oct 5, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @vstinner for commit c1adc06 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F158838%2Fmerge

The command will test the builders whose names match following regular expression: ARM64 macOS PR

The builders matched are:

  • ARM64 macOS PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Oct 5, 2026
gh-158810: Fix Py_ARRAY_LENGTH() macro on C++ #158812
Merged
@vstinner

vstinner commented Oct 5, 2026

Copy link
Copy Markdown
Member Author

Ah, the MSan failure is known, see: #151828 (comment).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
chris-eibl
chris-eibl approved these changes Oct 5, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Oct 5, 2026
@vstinner
Merge branch 'main' into arraylen_typeof
99f4d28
@vstinner
vstinner enabled auto-merge (squash) October 5, 2026 19:11
@vstinner

vstinner commented Oct 5, 2026

Copy link
Copy Markdown
Member Author

Tests / Hypothesis tests on Ubuntu (pull_request): Failing after 52m

It failed with "Error: Process completed with exit code 143." Strange. I click on re-run failed jobs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 85c03d4 into python:main Oct 6, 2026
94 of 96 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner deleted the arraylen_typeof branch October 6, 2026 00:06
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 6, 2026
vstinner added a commit that referenced this pull request Oct 13, 2026
@vstinner
[3.15] gh-158810: Fix Py_ARRAY_LENGTH() macro on C++ (#159315)
152185f 
* gh-158810: Fix Py_ARRAY_LENGTH() macro on C++ (#158812)

(cherry picked from commit b2bfbce)

* gh-158810: Use _Py_TYPEOF in Py_ARRAY_LENGTH() (#158838)

Fix the compiler warning "extension used" when building test_cext
with clang.

* test_cext no longer overrides the CC environment variable if it's
  already defined.
* test_cext now also logs __STRICT_ANSI__ macro.

(cherry picked from commit 85c03d4)

* Add Py_SETREF/XSETREF tests to test_cext
vstinner added a commit that referenced this pull request Oct 13, 2026
@vstinner
[3.14] gh-158810: Fix Py_ARRAY_LENGTH() macro on C++ (#159317)
931322b 
* [3.15] gh-158810: Fix Py_ARRAY_LENGTH() macro on C++ (#159315)

* gh-158810: Fix Py_ARRAY_LENGTH() macro on C++ (#158812)

(cherry picked from commit b2bfbce)

* gh-158810: Use _Py_TYPEOF in Py_ARRAY_LENGTH() (#158838)

Fix the compiler warning "extension used" when building test_cext
with clang.

* test_cext no longer overrides the CC environment variable if it's
  already defined.
* test_cext now also logs __STRICT_ANSI__ macro.

(cherry picked from commit 85c03d4)

* Add Py_SETREF/XSETREF tests to test_cext

(cherry picked from commit 152185f)

* Backport Py_CLEAR/Py_SETREF/Py_XSETREF from main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chris-eibl chris-eibl chris-eibl approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @bedevere-bot @chris-eibl
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.