GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-149044: Build test_cext with -Wall -Wextra by vstinner · Pull Request #158867 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Oct 5, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fix "unused parameter" warning/error in pycore_object_deferred.h and pycore_stackref.h.

Fix PySlot_END on C++: initialize all members.

  • Issue: Implement PEP 820 – PySlot: Unified slot system for the C API #149044

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vstinner
vstinner requested a review from Fidget-Spinner as a code owner October 5, 2026 15:11
@vstinner
vstinner marked this pull request as draft October 5, 2026 15:12
@bedevere-app bedevere-app Bot added the type-feature A feature request or enhancement label Oct 5, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Oct 5, 2026
Implement PEP 820 – PySlot: Unified slot system for the C API #149044
Closed
@vstinner vstinner mentioned this pull request Oct 5, 2026
gh-149044: Fix PySlot_END macro for C++ #158866
Merged
@vstinner vstinner added the skip news label Oct 5, 2026
@vstinner
pythongh-149044: Build test_cext with -Wall -Wextra
f313b85
@vstinner
vstinner force-pushed the text_cext_extra branch from 7ce1d7e to f313b85 Compare October 7, 2026 15:02
@vstinner vstinner removed the type-feature A feature request or enhancement label Oct 7, 2026
@vstinner
vstinner marked this pull request as ready for review October 7, 2026 15:03
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 7, 2026
@vstinner vstinner added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 7, 2026
@bedevere-bot

bedevere-bot commented Oct 7, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @vstinner for commit f313b85 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F158867%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 7, 2026
@vstinner

vstinner commented Oct 8, 2026

Copy link
Copy Markdown
Member Author

Only FreeBSD Refleaks buildbot failed with: Assertion failed: (strlen(arg) == arglen), function _Py_DecodeLocale, file Python/fileutils.c, line 733. That's a known issue, unrelated to this change (and I already fixed it.)

Good test_cext passed on all buildbots!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
vstinner merged commit b22a8c9 into python:main Oct 8, 2026
133 of 136 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
vstinner deleted the text_cext_extra branch October 8, 2026 01:26
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 8, 2026
vstinner added a commit that referenced this pull request Oct 13, 2026
@vstinner
[3.15] gh-157649: Check for reference leak in test_cext (#159296)
8514386
* gh-157649: Check for reference leak in test_cext (#158227)

test_cext now discovers and calls all "test" functions. On a debug
build, it also checks for reference leaks.

Fix a reference leak in test_virtual_object(): use a dealloc function
which calls Py_DECREF() on the type, and trigger an explicit garbage
collection.

(cherry picked from commit 7952713)

* gh-149044: Build test_cext with -Wall -Wextra (#158867)

(cherry picked from commit b22a8c9)
@vstinner vstinner mentioned this pull request Oct 13, 2026
[3.14] gh-157649: Check for reference leak in test_cext (#159296) #159314
Merged
vstinner added a commit that referenced this pull request Oct 13, 2026
@vstinner
[3.14] gh-157649: Check for reference leak in test_cext (#159296) (#1…
dd78c51
…59314)

* [3.15] gh-157649: Check for reference leak in test_cext (#159296)

* gh-157649: Check for reference leak in test_cext (#158227)

test_cext now discovers and calls all "test" functions. On a debug
build, it also checks for reference leaks.

Fix a reference leak in test_virtual_object(): use a dealloc function
which calls Py_DECREF() on the type, and trigger an explicit garbage
collection.

(cherry picked from commit 7952713)

* gh-149044: Build test_cext with -Wall -Wextra (#158867)

(cherry picked from commit b22a8c9)
(cherry picked from commit 8514386)

* Fix refleak in test_datetime()

Only call PyDateTime_IMPORT once to initialize PyDateTimeAPI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.