GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-159675: Use lazy urllib imports in saxutils by jelly · Pull Request #159676 · python/cpython

gh-159675: Use lazy urllib imports in saxutils #159676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

StanFromIreland merged 2 commits into python:main from jelly:saxutils-lazy-load-urllib

Oct 19, 2026

Uh oh!

There was an error while loading. Please reload this page.

Merged

gh-159675: Use lazy urllib imports in saxutils #159676

Show file tree

Hide file tree

Changes from all commits

Commits

Show all changes

2 commits

Select commit Hold shift + click to select a range

66c3450

Use lazy urllib imports in saxutils

jelly Oct 18, 2026

b961b18

Tidy up a few more `import`s

StanFromIreland Oct 19, 2026

File filter

Filter by extension .py (2) All 1 file type selected

Viewed files

Clear filters

Conversations

Failed to load comments.

Uh oh!

There was an error while loading. Please reload this page.

Jump to

Jump to file

Failed to load files.

Uh oh!

There was an error while loading. Please reload this page.

Diff view

Unified

Split

Hide whitespace

Diff view

Unified

Split

Hide whitespace

There are no files selected for viewing

10 changes: 8 additions & 2 deletions 10 Lib/test/test_sax.py

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -24,8 +24,8 @@
		import sys
		from urllib.error import URLError
		import urllib.request
		from test.support import os_helper
		from test.support import findfile, check__all__
		from test.support import (check__all__, cpython_only, findfile,
		import_helper, os_helper)
		from test.support.os_helper import FakePath, TESTFN


Expand Down Expand Up		@@ -1600,6 +1600,12 @@ def test_deprecated__version__and__date__(self):
		getattr(module, "version")
		self.assertEqual(cm.filename, __file__)

Comment thread jelly marked this conversation as resolved. Resolved Uh oh! There was an error while loading. Please reload this page.
		@cpython_only
		def test_lazy_import(self):
		import_helper.ensure_lazy_imports(
		"xml.sax.saxutils", {"urllib.parse", "urllib.request"}
		)


		if __name__ == "__main__":
		unittest.main()

8 changes: 5 additions & 3 deletions 8 Lib/xml/sax/saxutils.py

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -3,9 +3,12 @@
		convenience of application and driver writers.
		"""

		import os, urllib.parse, urllib.request
		import io
		import codecs
		import io
		import os
		import sys
		lazy import urllib.parse
		lazy import urllib.request
		from . import handler
		from . import xmlreader

Expand Down Expand Up		@@ -70,7 +73,6 @@ def quoteattr(data, entities={}):

		def _gettextwriter(out, encoding):
		if out is None:
		import sys
		return sys.stdout

		if isinstance(out, io.TextIOBase):
Expand Down

Oops, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.