GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-155426: correctly reject non-bytes keys in `hmac.digest` (GH-155427) by miss-islington · Pull Request #159744 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Oct 19, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This only affects keys of length smaller than the HMAC blocksize
since larger keys are hashed first.
(cherry picked from commit 197d332)

Co-authored-by: Bénédikt Tran [email protected]

  • Issue: Raise TypeError in pure Python hmac.digest for non-bytes keys #155426

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@picnixz @miss-islington
pythongh-155426: correctly reject non-bytes keys in hmac.digest (py…
df145eb 
…thonGH-155427)

This only affects keys of length smaller than the HMAC blocksize
since larger keys are hashed first.
(cherry picked from commit 197d332)

Co-authored-by: Bénédikt Tran <[email protected]>
@miss-islington
miss-islington requested review from gpshead and picnixz as code owners October 19, 2026 19:38
@bedevere-app bedevere-app Bot mentioned this pull request Oct 19, 2026
Raise TypeError in pure Python hmac.digest for non-bytes keys #155426
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Oct 19, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Oct 19, 2026
gh-155426: correctly reject non-bytes keys in hmac.digest #155427
Merged
picnixz
picnixz reviewed Oct 19, 2026
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2026-08-09-14-06-27.gh-issue-155426.zZVPMd.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
Update Misc/NEWS.d/next/Library/2026-08-09-14-06-27.gh-issue-155426.z…
3bfe707 
…ZVPMd.rst
picnixz
picnixz approved these changes Oct 19, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Oct 19, 2026
@picnixz
picnixz enabled auto-merge (squash) October 19, 2026 19:41
@picnixz
picnixz merged commit cf0658d into python:3.14 Oct 19, 2026
92 of 94 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 19, 2026
@miss-islington
miss-islington deleted the backport-197d332-3.14 branch October 19, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes
@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@miss-islington @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.