GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-155426: correctly reject non-bytes keys in `hmac.digest` by picnixz · Pull Request #155427 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Aug 9, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Raise TypeError in pure Python hmac.digest for non-bytes keys #155426

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@picnixz
picnixz requested a review from gpshead as a code owner August 9, 2026 12:10
@bedevere-app bedevere-app Bot added the awaiting core review label Aug 9, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Aug 9, 2026
Raise TypeError in pure Python hmac.digest for non-bytes keys #155426
Closed
@picnixz
pythongh-155426: correctly accept bytes-like keys in hmac.digest
0c1bf69 
This only affects keys of length smaller than the HMAC blocksize
since larger keys are hashed first.
@picnixz
picnixz force-pushed the meta/crypto/py/hmac/key-ljust-invalid-155426 branch from fe28b30 to 0c1bf69 Compare August 9, 2026 12:42
@picnixz picnixz changed the title gh-155426: correctly accept bytes-like keys in hmac.digest gh-155426: correctly reject non-bytes keys in hmac.digest Aug 9, 2026
@picnixz picnixz added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Aug 9, 2026
picnixz
picnixz commented Aug 9, 2026
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2026-08-09-14-06-27.gh-issue-155426.zZVPMd.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
Update Misc/NEWS.d/next/Library/2026-08-09-14-06-27.gh-issue-155426.z…
cacd824 
…ZVPMd.rst
@picnixz picnixz removed the needs backport to 3.13 only security fixes label Oct 19, 2026
@picnixz
Merge branch 'main' into meta/crypto/py/hmac/key-ljust-invalid-155426
0fee262
@picnixz picnixz self-assigned this Oct 19, 2026
@picnixz
picnixz merged commit 197d332 into python:main Oct 19, 2026
53 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 19, 2026
@miss-islington-app

miss-islington-app Bot commented Oct 19, 2026

Copy link
Copy Markdown

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
picnixz deleted the meta/crypto/py/hmac/key-ljust-invalid-155426 branch October 19, 2026 19:37
@bedevere-app

bedevere-app Bot commented Oct 19, 2026

Copy link
Copy Markdown

GH-159743 is a backport of this pull request to the 3.15 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Oct 19, 2026
@bedevere-app

bedevere-app Bot commented Oct 19, 2026

Copy link
Copy Markdown

GH-159744 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 19, 2026
picnixz added a commit that referenced this pull request Oct 19, 2026
@miss-islington @picnixz
[3.15] gh-155426: correctly reject non-bytes keys in hmac.digest (G…
e0685b7 
…H-155427) (#159743)

This only affects keys of length smaller than the HMAC blocksize
since larger keys are hashed first.

(cherry picked from commit 197d332)

---------

Co-authored-by: Bénédikt Tran <[email protected]>
picnixz added a commit that referenced this pull request Oct 19, 2026
@miss-islington @picnixz
[3.14] gh-155426: correctly reject non-bytes keys in hmac.digest (G…
cf0658d 
…H-155427) (#159744)

This only affects keys of length smaller than the HMAC blocksize
since larger keys are hashed first.

(cherry picked from commit 197d332)

---------

Co-authored-by: Bénédikt Tran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@picnixz picnixz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.