GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-159739: Preserve the syntax error if metadata allocation fails by jelle-openai · Pull Request #159751 · python/cpython

Conversation

@jelle-openai

@jelle-openai jelle-openai commented Oct 19, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Restore the original exception when optional syntax-error metadata
cannot be allocated.

Backport to 3.15 and 3.14. On 3.14, also remove the erroneous
Py_DECREF(the_source): the N format unit already consumed that
reference.

  • Issue: Fix minor safety issues #159739

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
pythongh-159739: Preserve the syntax error if metadata allocation fails
f3680ad 
Restore the original exception when optional syntax-error metadata
cannot be allocated.

Backport to 3.15 and 3.14. On 3.14, also remove the erroneous
Py_DECREF(the_source): the N format unit already consumed that
reference.
@jelle-openai
jelle-openai requested review from lysnikolaou and pablogsal as code owners October 19, 2026 20:07
@bedevere-app bedevere-app Bot mentioned this pull request Oct 19, 2026
Fix minor safety issues #159739
Open
@bedevere-app bedevere-app Bot added the awaiting review label Oct 19, 2026
@JelleZijlstra JelleZijlstra added needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Oct 19, 2026
@JelleZijlstra
JelleZijlstra merged commit 9c239fb into python:main Oct 20, 2026
62 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting review label Oct 20, 2026
@miss-islington-app

miss-islington-app Bot commented Oct 20, 2026

Copy link
Copy Markdown

Thanks @jelle-openai for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Oct 20, 2026

Copy link
Copy Markdown

GH-159845 is a backport of this pull request to the 3.15 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Oct 20, 2026
@bedevere-app

bedevere-app Bot commented Oct 20, 2026

Copy link
Copy Markdown

GH-159846 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 20, 2026
JelleZijlstra pushed a commit that referenced this pull request Oct 20, 2026
@miss-islington @jelle-openai
[3.15] gh-159739: Preserve the syntax error if metadata allocation fa…
25b96b1 
…ils (GH-159751) (#159845)

Restore the original exception when optional syntax-error metadata
cannot be allocated.
(cherry picked from commit 9c239fb)

Co-authored-by: Jelle Zijlstra <[email protected]>
JelleZijlstra added a commit that referenced this pull request Oct 20, 2026
@miss-islington @jelle-openai @JelleZijlstra
[3.14] gh-159739: Preserve the syntax error if metadata allocation fa…
28cb41d 
…ils (GH-159751) (#159846)

Restore the original exception when optional syntax-error metadata
cannot be allocated.
(cherry picked from commit 9c239fb)

Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jelle-openai @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.