GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-159739: Fix reference and error handling in warnings by jelle-openai · Pull Request #159758 · python/cpython

Conversation

jelle-openai commented Oct 19, 2026 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Do not release the borrowed skip_file_prefixes argument, and stop if
allocation of the fallback filename fails.

Backport to 3.15 and 3.14.

Issue: Fix minor safety issues #159739

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-159739: Fix reference and error handling in warnings

78574c3

Do not release the borrowed skip_file_prefixes argument, and stop if
allocation of the fallback filename fails.

Backport to 3.15 and 3.14.

bedevere-app Bot mentioned this pull request

Oct 19, 2026

Fix minor safety issues #159739

Open

bedevere-app Bot added the awaiting review label

Oct 19, 2026

JelleZijlstra commented Oct 19, 2026

Copy link

Copy Markdown

Member

Verified this crash:

>>> class X(tuple): pass
... 
>>> warnings.warn("hi", skip_file_prefixes=X())
<python-input-11>:1: UserWarning: hi
Assertion failed: (!_Py_IsStaticImmortal(op)), function Py_DECREF_MORTAL, file pycore_object.h, line 412.
Abort trap: 6

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JelleZijlstra added needs backport to 3.14

bugs and security fixes

needs backport to 3.15 bugs and security fixes labels

Oct 19, 2026

gpshead self-assigned this

Oct 19, 2026

gpshead reviewed

Oct 19, 2026

View reviewed changes

gpshead left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider a regression test?

class T(tuple): pass
for _ in range(3):
    with self.module.catch_warnings(record=True):
        self.module.warn("msg", skip_file_prefixes=T())

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JelleZijlstra reacted with thumbs up emoji

All reactions

👍 1 reaction

gpshead reviewed

Oct 19, 2026

View reviewed changes

Comment thread

Misc/NEWS.d/next/Core_and_Builtins/2026-10-19-19-33-35.gh-issue-159739.f81734.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

gpshead removed their assignment

Oct 19, 2026

JelleZijlstra added 3 commits

October 19, 2026 14:24


          new test, fix NEWS

b508baa


          Merge branch 'main' into jelle/codex/pythongh-159739-warnings-errors

7756fc0

a0a945b

JelleZijlstra merged commit fab1405 into python:main

Oct 21, 2026

56 checks passed

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot commented Oct 21, 2026

Copy link

Copy Markdown

Thanks @jelle-openai for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting review label

Oct 21, 2026

miss-islington-app Bot commented Oct 21, 2026

Copy link

Copy Markdown

Sorry, @jelle-openai and @JelleZijlstra, I could not cleanly backport this to 3.14 due to a conflict.

Please backport manually with cherry_picker, see the devguide for more information.

cherry_picker fab1405da8c93429ab1a1d3d3e1779d15b7223a2 3.14

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot commented Oct 21, 2026

Copy link

Copy Markdown

GH-160022 is a backport of this pull request to the 3.15 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot assigned JelleZijlstra

Oct 21, 2026

bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label

Oct 21, 2026

jelle-openai mentioned this pull request

Oct 21, 2026

[3.14] gh-159739: Fix reference and error handling in warnings (GH-159758) #160085

Merged

bedevere-app Bot commented Oct 21, 2026

Copy link

Copy Markdown

GH-160085 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label

Oct 21, 2026

JelleZijlstra pushed a commit that referenced this pull request

Oct 21, 2026


          [3.15] gh-159739: Fix reference and error handling in warnings (GH-15…

2c17c77

…9758) (#160022)

Do not release the borrowed skip_file_prefixes argument, and stop if
allocation of the fallback filename fails.
(cherry picked from commit fab1405)

Co-authored-by: Jelle Zijlstra <[email protected]>

JelleZijlstra pushed a commit that referenced this pull request

Oct 21, 2026


          [3.14] gh-159739: Fix reference and error handling in warnings (GH-15…

a03d287

…9758) (#160085)

Do not release the borrowed skip_file_prefixes argument, and stop if
allocation of the fallback filename fails.

(cherry picked from commit fab1405)

Reviewers

gpshead

gpshead left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

JelleZijlstra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

jelle-openai commented Oct 19, 2026 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JelleZijlstra commented Oct 19, 2026

Uh oh!

gpshead left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

miss-islington-app Bot commented Oct 21, 2026

Uh oh!

miss-islington-app Bot commented Oct 21, 2026

Uh oh!

bedevere-app Bot commented Oct 21, 2026

Uh oh!

bedevere-app Bot commented Oct 21, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jelle-openai commented Oct 19, 2026 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.