GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-159739: Fix crash in _PyTuple_Resize() with an invalid size by gpshead · Pull Request #159804 · python/cpython

Conversation

@gpshead

@gpshead gpshead commented Oct 19, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fix a crash in _PyTuple_Resize when resizing a non-empty tuple to a
negative or too large size. It now raises SystemError or
MemoryError respectively.

  • Issue: Fix minor safety issues #159739

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gpshead gpshead self-assigned this Oct 19, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Oct 19, 2026
Fix minor safety issues #159739
Open
@gpshead
gpshead force-pushed the claude/elegant-faraday-p69m3r branch from 339d31a to 48e893e Compare October 19, 2026 22:34
@python python deleted a comment from python-cla-bot Bot Oct 19, 2026
@python-cla-bot

python-cla-bot Bot commented Oct 19, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gpshead added 2 commits October 19, 2026 22:42
@gpshead
pythongh-159739: Add a regression test for the _PyTuple_Resize() leak
ec9abd6 
Check that the items of a non-empty tuple are released when the
reallocation in _PyTuple_Resize() fails.
@gpshead
pythongh-159739: Fix crash in _PyTuple_Resize() with an invalid size
db04f57 
_PyTuple_Resize() did not validate newsize for non-empty tuples.

Raise SystemError for a negative size and MemoryError for a too-large size,
like PyTuple_New() already does for the empty-tuple path.
@gpshead
gpshead force-pushed the claude/elegant-faraday-p69m3r branch from 1afc2ec to db04f57 Compare October 19, 2026 22:43
@gpshead gpshead added needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Oct 19, 2026
@gpshead
pythongh-159739: Remove the realloc failure test from test__tuple_resize
ff99345 
It relied on a huge allocation request failing, which is not portable:
TSan aborts on it and it succeeds on wasm32 (WASI).
@gpshead
gpshead marked this pull request as ready for review October 20, 2026 22:59
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 20, 2026
@gpshead
gpshead merged commit c360884 into python:main Oct 20, 2026
58 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 20, 2026
@miss-islington-app

miss-islington-app Bot commented Oct 20, 2026

Copy link
Copy Markdown

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Oct 20, 2026

Copy link
Copy Markdown

GH-159976 is a backport of this pull request to the 3.15 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Oct 20, 2026
@bedevere-app

bedevere-app Bot commented Oct 20, 2026

Copy link
Copy Markdown

GH-159977 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 20, 2026
gpshead added a commit that referenced this pull request Oct 21, 2026
@miss-islington @gpshead
[3.15] gh-159739: Fix crash in _PyTuple_Resize() with an invalid size (…
f97464b 
…GH-159804) (#159976)

gh-159739: Fix crash in _PyTuple_Resize() with an invalid size (GH-159804)

_PyTuple_Resize() did not validate newsize for non-empty tuples.

Raise SystemError for a negative size and MemoryError for a too-large size,
like PyTuple_New() already does for the empty-tuple path.
(cherry picked from commit c360884)

Co-authored-by: Gregory P. Smith <[email protected]>
gpshead added a commit that referenced this pull request Oct 21, 2026
@miss-islington @gpshead
[3.14] gh-159739: Fix crash in _PyTuple_Resize() with an invalid size (…
86795c8 
…GH-159804) (#159977)

gh-159739: Fix crash in _PyTuple_Resize() with an invalid size (GH-159804)

_PyTuple_Resize() did not validate newsize for non-empty tuples.

Raise SystemError for a negative size and MemoryError for a too-large size,
like PyTuple_New() already does for the empty-tuple path.
(cherry picked from commit c360884)

Co-authored-by: Gregory P. Smith <[email protected]>
@gpshead gpshead added the sprint label Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gpshead gpshead

Labels

sprint

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@gpshead
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.