GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-143632: Fix the musl check for PR_SET_VMA_ANON_NAME by serhiy-storchaka · Pull Request #159886 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Oct 20, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Match on the host triplet instead of the unset $ac_cv_libc. configure regenerated with autoconf 2.72.

Verified: glibc x86_64 unchanged (check runs, macro defined), musl x86_64 unchanged (skipped), musl i686 now builds without ac_cv_have_decl_PR_SET_VMA_ANON_NAME=no.

Matching the triplet rather than __GLIBC__ keeps the check enabled on Android/bionic, where the headers do not clash.

🤖 Generated with Claude Code

  • Issue: configure: the musl guard for PR_SET_VMA_ANON_NAME tests an unset variable #159885
  • Issue: failure building Python 3.15.0a3 through 3.15.0 release on Alpine #143632

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@serhiy-storchaka
serhiy-storchaka requested review from AA-Turner, corona10, emmatyping, erlend-aasland and itamaro as code owners October 20, 2026 15:03
@bedevere-app bedevere-app Bot mentioned this pull request Oct 20, 2026
configure: the musl guard for PR_SET_VMA_ANON_NAME tests an unset variable #159885
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 20, 2026
@serhiy-storchaka @claude
pythongh-143632: Fix the musl check for PR_SET_VMA_ANON_NAME
dd58805
The guard added by pythongh-143730 tested $ac_cv_libc, which is never set, so the
check always ran and the build could fail on the struct prctl_mm_map
redefinition it was meant to avoid.  Match on the host triplet instead.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
@serhiy-storchaka
serhiy-storchaka force-pushed the gh-159885-musl-prctl branch from 4284433 to dd58805 Compare October 20, 2026 15:53
@serhiy-storchaka serhiy-storchaka changed the title gh-159885: Fix the musl check for PR_SET_VMA_ANON_NAME gh-143632: Fix the musl check for PR_SET_VMA_ANON_NAME Oct 20, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Oct 20, 2026
failure building Python 3.15.0a3 through 3.15.0 release on Alpine #143632
Open
corona10
corona10 approved these changes Oct 20, 2026
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Oct 20, 2026
@serhiy-storchaka
serhiy-storchaka merged commit f37e821 into python:main Oct 20, 2026
95 of 98 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 20, 2026
@serhiy-storchaka
serhiy-storchaka deleted the gh-159885-musl-prctl branch October 20, 2026 17:29
@serhiy-storchaka serhiy-storchaka added needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Oct 20, 2026
@miss-islington-app

miss-islington-app Bot commented Oct 20, 2026

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington-app

miss-islington-app Bot commented Oct 20, 2026

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington-app

miss-islington-app Bot commented Oct 20, 2026

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.14 due to a conflict.

Please backport manually with cherry_picker, see the devguide for more information.

cherry_picker f37e82139a24c4f1bd84c7d9111f44719b94fff5 3.14
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app

bedevere-app Bot commented Oct 20, 2026

Copy link
Copy Markdown

GH-159919 is a backport of this pull request to the 3.15 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington-app miss-islington-app Bot assigned serhiy-storchaka Oct 20, 2026
@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Oct 20, 2026
@serhiy-storchaka serhiy-storchaka removed the needs backport to 3.14 bugs and security fixes label Oct 20, 2026
serhiy-storchaka added a commit that referenced this pull request Oct 20, 2026
@miss-islington @serhiy-storchaka @claude
[3.15] gh-143632: Fix the musl check for PR_SET_VMA_ANON_NAME (GH-159886
eb9ec94
) (GH-159919)

The guard added by gh-143730 tested $ac_cv_libc, which is never set, so the
check always ran and the build could fail on the struct prctl_mm_map
redefinition it was meant to avoid.  Match on the host triplet instead.
(cherry picked from commit f37e821)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Claude Opus 5 (1M context) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping is a code owner
@itamaro itamaro Awaiting requested review from itamaro itamaro is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@serhiy-storchaka serhiy-storchaka

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@serhiy-storchaka @corona10
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.