GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-159739: Keep descriptor metadata dictionaries alive during insertion by jelle-openai · Pull Request #160193 · python/cpython

Conversation

@jelle-openai

@jelle-openai jelle-openai commented Oct 22, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The classmethod and staticmethod metadata setters dropped their reference to the descriptor dictionary before inserting the new value. A key comparison or value finalizer can replace the dictionary during insertion, leaving the operation using released memory. Keep the dictionary alive until insertion finishes. Backport to 3.15 and 3.14.

  • Issue: Fix minor safety issues #159739

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jelle-openai
pythongh-159739: Keep descriptor metadata dictionaries alive during i…
e031e9b 
…nsertion

The classmethod and staticmethod metadata setters dropped their reference to the descriptor dictionary before inserting the new value. A key comparison or value finalizer can replace the dictionary during insertion, leaving the operation using released memory. Keep the dictionary alive until insertion finishes. Backport to 3.15 and 3.14.
@bedevere-app bedevere-app Bot mentioned this pull request Oct 22, 2026
Fix minor safety issues #159739
Open
@bedevere-app bedevere-app Bot added the awaiting review label Oct 22, 2026
@JelleZijlstra
JelleZijlstra merged commit a076a55 into python:main Oct 22, 2026
58 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Oct 22, 2026

Copy link
Copy Markdown

Thanks @jelle-openai for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra JelleZijlstra added needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Oct 22, 2026
@bedevere-app bedevere-app Bot removed the awaiting review label Oct 22, 2026
@miss-islington-app

miss-islington-app Bot commented Oct 22, 2026

Copy link
Copy Markdown

Thanks @jelle-openai for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Oct 22, 2026

Copy link
Copy Markdown

Thanks @jelle-openai for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Oct 22, 2026

Copy link
Copy Markdown

GH-160382 is a backport of this pull request to the 3.15 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Oct 22, 2026
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 22, 2026
@jelle-openai @miss-islington
pythongh-159739: Keep descriptor metadata dictionaries alive during i…
b4f121d 
…nsertion (pythonGH-160193)

The classmethod and staticmethod metadata setters dropped their reference to the descriptor dictionary before inserting the new value. A key comparison or value finalizer can replace the dictionary during insertion, leaving the operation using released memory. Keep the dictionary alive until insertion finishes. Backport to 3.15 and 3.14.
(cherry picked from commit a076a55)

Co-authored-by: Jelle Zijlstra <[email protected]>
@bedevere-app

bedevere-app Bot commented Oct 22, 2026

Copy link
Copy Markdown

GH-160383 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 22, 2026
@miss-islington-app

miss-islington-app Bot commented Oct 22, 2026

Copy link
Copy Markdown

Sorry @jelle-openai and @JelleZijlstra, I had trouble completing the backport.

Please retry by removing and re-adding the "needs backport to 3.14" label.
If that does not work, please backport manually with cherry_picker, see the devguide for more information.

cherry_picker a076a55ad2a318cd8b7010d85ccf21ccd0a98555 3.14
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned JelleZijlstra Oct 22, 2026
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 22, 2026
@jelle-openai @miss-islington
pythongh-159739: Keep descriptor metadata dictionaries alive during i…
e9bde21 
…nsertion (pythonGH-160193)

The classmethod and staticmethod metadata setters dropped their reference to the descriptor dictionary before inserting the new value. A key comparison or value finalizer can replace the dictionary during insertion, leaving the operation using released memory. Keep the dictionary alive until insertion finishes. Backport to 3.15 and 3.14.
(cherry picked from commit a076a55)

Co-authored-by: Jelle Zijlstra <[email protected]>
@miss-islington-app

miss-islington-app Bot commented Oct 22, 2026

Copy link
Copy Markdown

Sorry @jelle-openai and @JelleZijlstra, I had trouble completing the backport.

Please retry by removing and re-adding the "needs backport to 3.15" label.
If that does not work, please backport manually with cherry_picker, see the devguide for more information.

cherry_picker a076a55ad2a318cd8b7010d85ccf21ccd0a98555 3.15
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra pushed a commit that referenced this pull request Oct 23, 2026
@miss-islington @jelle-openai
[3.15] gh-159739: Keep descriptor metadata dictionaries alive during …
5c50b6a 
…insertion (GH-160193) (#160382)

The classmethod and staticmethod metadata setters dropped their reference to the descriptor dictionary before inserting the new value. A key comparison or value finalizer can replace the dictionary during insertion, leaving the operation using released memory. Keep the dictionary alive until insertion finishes. Backport to 3.15 and 3.14.
(cherry picked from commit a076a55)

Co-authored-by: Jelle Zijlstra <[email protected]>
JelleZijlstra pushed a commit that referenced this pull request Oct 23, 2026
@miss-islington @jelle-openai
[3.14] gh-159739: Keep descriptor metadata dictionaries alive during …
a2916fe 
…insertion (GH-160193) (#160383)

The classmethod and staticmethod metadata setters dropped their reference to the descriptor dictionary before inserting the new value. A key comparison or value finalizer can replace the dictionary during insertion, leaving the operation using released memory. Keep the dictionary alive until insertion finishes. Backport to 3.15 and 3.14.
(cherry picked from commit a076a55)

Co-authored-by: Jelle Zijlstra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@JelleZijlstra JelleZijlstra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jelle-openai @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.