GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-36675: Remove obsolete code. by JulienPalard · Pull Request #16024 · python/cpython

Conversation

@JulienPalard

@JulienPalard JulienPalard commented Sep 12, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Does no longer work since Sphinx moved the trim_doctest_flag option in
the configuration.

This does not close the issue, but while I was there, I cleaned this code that could no longer work.

https://bugs.python.org/issue36675

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JulienPalard
bpo-36675: Remove obsolete code.
904de60 
Does no longer work since Sphinx moved the trim_doctest_flag option in
the configuration.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 12, 2019
@bedevere-bot bedevere-bot added the awaiting core review label Sep 12, 2019
@JulienPalard JulienPalard added skip news and removed awaiting core review labels Sep 12, 2019
gpshead
gpshead approved these changes Sep 12, 2019
View reviewed changes
@bedevere-bot bedevere-bot added the awaiting merge label Sep 12, 2019
@gpshead gpshead added the needs backport to 3.8 label Sep 12, 2019
@gpshead
gpshead merged commit 2c910c1 into python:master Sep 12, 2019
@miss-islington

miss-islington commented Sep 12, 2019

Copy link
Copy Markdown
Contributor

Thanks @JulienPalard for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Sep 12, 2019
@bedevere-bot

bedevere-bot commented Sep 12, 2019

Copy link
Copy Markdown

GH-16030 is a backport of this pull request to the 3.8 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Sep 12, 2019
miss-islington added a commit that referenced this pull request Sep 12, 2019
@miss-islington @JulienPalard
bpo-36675: Remove obsolete code. (GH-16024)
94a6847 
Does no longer work since Sphinx moved the trim_doctest_flag option in
the configuration.
(cherry picked from commit 2c910c1)

Co-authored-by: Julien Palard <[email protected]>
@JulienPalard
JulienPalard deleted the issue36675 branch October 22, 2019 16:22
@stevendaprano stevendaprano mentioned this pull request May 5, 2022
Doctest directives and comments missing from code samples #80856
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@JulienPalard @miss-islington @bedevere-bot @gpshead @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.