GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-161078: Correct unstable C API PEP references by TheLouisMahdi · Pull Request #161158 · python/cpython

Conversation

@TheLouisMahdi

@TheLouisMahdi TheLouisMahdi commented Nov 2, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Summary

Correct the Unstable C API tier references from PEP 697 to PEP 689 in Doc/whatsnew/3.12.rst, including the associated internal label.

The separate PEP 697 entry remains unchanged.

Closes #161078.

Testing

  • Full Sphinx HTML documentation build with Python 3.12.16: passed with zero warnings or errors.
  • Official documentation dependencies installed from Doc/pylock.toml.
  • Verified PEP 689 and PEP 697 references.
  • Validated all 1,192 local HTML fragment links on the affected page.
  • git diff --check: passed.

Sol 6.1 High was used to assist with preparing the change and validation.

  • Issue: What's New in 3.12 credits the unstable C API tier to PEP 697 instead of PEP 689 #161078

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
chatgpt-codex-connector[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@TheLouisMahdi
pythongh-161078: Correct unstable C API PEP references
32a8408
@TheLouisMahdi
TheLouisMahdi requested a review from AA-Turner as a code owner November 2, 2026 07:18
@python-cla-bot

python-cla-bot Bot commented Nov 2, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added the awaiting review label Nov 2, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Nov 2, 2026
What's New in 3.12 credits the unstable C API tier to PEP 697 instead of PEP 689 #161078
Open
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news labels Nov 2, 2026
@github-project-automation github-project-automation Bot added this to Docs PRs Nov 2, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Nov 2, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T07:20:36.552569Z 32a8408 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@read-the-docs-community

read-the-docs-community Bot commented Nov 2, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #35608463 | 📁 Comparing 53a8277 against main (67683da)

  🔍 Preview build  

49 files changed · ± 49 modified

± Modified

  • builtins/stdtypes.html
  • deprecations/pending-removal-in-3.15.html
  • howto/enum.html
  • howto/regex.html
  • howto/sorting.html
  • library/abc.html
  • library/argparse.html
  • library/binascii.html
  • library/configparser.html
  • library/contextlib.html
  • and 39 more...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Aniketsy
Aniketsy reviewed Nov 2, 2026
View reviewed changes

@Aniketsy Aniketsy left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
CAM-Gerlach
CAM-Gerlach reviewed Nov 3, 2026
View reviewed changes

@CAM-Gerlach CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself is correct, except that the existing ref target label should be moved to the correct location, rather than simply replaced, to avoid breaking existing users. Please apply it by clicking the "Apply suggestion" button, or via the Files pane.

It's not backportable all the way to the original version, but the What's New is often accessed from newer versions and remains present perpetually, so I don't think this error has to and don't see the harm there.

I am a bit concerned about how much genuine human input was present here, given the comments on # --please respond, as a human, not an agent, confirming you've personally taken responsibly for this. However, given it is a trivial, correct and not substantial enough to be copyrightable change, I'm not sure its enough of an issue in practice to block this on its own.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/whatsnew/3.12.rst
Comment on lines 1886 to 1888
(Contributed by Petr Viktorin in :gh:`101101`.)

* :pep:`697`: Add an API for extending types whose instance memory layout is

@CAM-Gerlach CAM-Gerlach Nov 3, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(Contributed by Petr Viktorin in :gh:`101101`.)
.. _whatsnew312-pep697:
* :pep:`697`: Add an API for extending types whose instance memory layout is

Move the existing ref target label to the correct place, and avoid breaking anyone currently relying on it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@kadrqwer kadrqwer Nov 3, 2026

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@TheLouisMahdi TheLouisMahdi Nov 3, 2026

Copy link
Copy Markdown
Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(Contributed by Petr Viktorin in :gh:101101.)
.. _whatsnew312-pep697:

  • :pep:697: Add an API for extending types whose instance memory layout is
    Unable to apply suggestions when viewing a specific commit range.
    Move the existing ref target label to the correct place, and avoid breaking anyone currently relying on it.

Thanks for the detailed review. You're right about the existing reference target.

I've updated the patch to preserve whatsnew312-pep697 at the actual PEP 697 section while keeping whatsnew312-pep689 at the Unstable C API entry. This should preserve existing links while correcting the reference.

Regarding your concern about human involvement, I used AI assistance as disclosed in the PR description. I understand the change, have reviewed the patch, and take responsibility for the contribution.

Thanks again for pointing this out.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@CAM-Gerlach CAM-Gerlach added needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Nov 3, 2026
@CAM-Gerlach CAM-Gerlach moved this from Todo to In Progress in Docs PRs Nov 3, 2026
@TheLouisMahdi
pythongh-161078: Preserve the PEP 697 documentation anchor
53a8277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach left review comments
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
+2 more reviewers
@Aniketsy Aniketsy Aniketsy left review comments
@kadrqwer kadrqwer kadrqwer left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review docs Documentation in the Doc dir needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes skip news

Projects

Docs PRs
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

What's New in 3.12 credits the unstable C API tier to PEP 697 instead of PEP 689

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@TheLouisMahdi @CAM-Gerlach @Aniketsy @kadrqwer
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.