GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-38081: Add more non-fatal error codes for ntpath.realpath by zooba · Pull Request #16156 · python/cpython

Conversation

@zooba

@zooba zooba commented Sep 15, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue38081

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zooba
bpo-38081: Add more non-fatal error codes for ntpath.realpath
180791f
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 15, 2019
@bedevere-bot bedevere-bot added the awaiting core review label Sep 15, 2019
@zooba zooba added needs backport to 3.8 OS-windows skip news and removed awaiting core review labels Sep 15, 2019
eryksun
eryksun reviewed Sep 15, 2019
View reviewed changes
Comment thread Lib/ntpath.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
eryksun
eryksun reviewed Sep 15, 2019
View reviewed changes
Comment thread Lib/ntpath.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@zooba
Clarifies comments and adds TODO for bpo-38186
5b29e90
@zooba
zooba merged commit 89b8933 into python:master Sep 16, 2019
@zooba
zooba deleted the bpo-38081 branch September 16, 2019 14:25
@miss-islington

miss-islington commented Sep 16, 2019

Copy link
Copy Markdown
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Sep 16, 2019

Copy link
Copy Markdown
Contributor

Sorry @zooba, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 89b8933bb537179f81003928786c5cc6183af591 3.8
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned zooba Sep 16, 2019
@zooba zooba added needs backport to 3.8 and removed needs backport to 3.8 labels Sep 16, 2019
@miss-islington

miss-islington commented Sep 16, 2019

Copy link
Copy Markdown
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 16, 2019
@zooba @miss-islington
bpo-38081: Add more non-fatal error codes for ntpath.realpath (python…
ea1f8f2 
…GH-16156)

(cherry picked from commit 89b8933)

Co-authored-by: Steve Dower <[email protected]>
@bedevere-bot

bedevere-bot commented Sep 16, 2019

Copy link
Copy Markdown

GH-16187 is a backport of this pull request to the 3.8 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Sep 16, 2019
miss-islington added a commit that referenced this pull request Sep 16, 2019
@miss-islington @zooba
bpo-38081: Add more non-fatal error codes for ntpath.realpath (GH-16156)
4924d55 
(cherry picked from commit 89b8933)

Co-authored-by: Steve Dower <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eryksun eryksun eryksun left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@zooba zooba

Labels

OS-windows skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@zooba @miss-islington @bedevere-bot @eryksun @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.