GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111178: Set function=False by default in support.check_sanitizer() by vstinner · Pull Request #161640 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Nov 8, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Update also libregrtest.utils to detect function sanitizer (-fsanitize=function).

  • Issue: UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-111178: Set function=False by default in support.check_sanit…
2519b43 
…izer()

Update also libregrtest.utils to detect function sanitizer
(-fsanitize=function).
@vstinner vstinner added skip news needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Nov 8, 2026
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 8, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Nov 8, 2026
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178
Closed
@vstinner

vstinner commented Nov 8, 2026

Copy link
Copy Markdown
Member Author

The function parameter was added to check_sanitizer() by commit 643dd51. I made the change, but I don't remember why it's function=True by default. IMO it's a mistake and it should be function=False by default, as other parameters.

See also #111178.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 4e10d4f into python:main Nov 9, 2026
108 of 110 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner deleted the sanitize_function branch November 9, 2026 23:25
@miss-islington-app

miss-islington-app Bot commented Nov 9, 2026

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Nov 9, 2026
@miss-islington-app

miss-islington-app Bot commented Nov 9, 2026

Copy link
Copy Markdown

Sorry, @vstinner, I could not cleanly backport this to 3.15 due to a conflict.

Please backport manually with cherry_picker, see the devguide for more information.

cherry_picker 4e10d4fef5c073faaaf04ce5e03749a5dbe7716b 3.15
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned vstinner Nov 9, 2026
@miss-islington-app

miss-islington-app Bot commented Nov 9, 2026

Copy link
Copy Markdown

Sorry, @vstinner, I could not cleanly backport this to 3.14 due to a conflict.

Please backport manually with cherry_picker, see the devguide for more information.

cherry_picker 4e10d4fef5c073faaaf04ce5e03749a5dbe7716b 3.14
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner added a commit to vstinner/cpython that referenced this pull request Nov 9, 2026
@vstinner
pythongh-111178: Set function=False by default in support.check_sanit…
9b2a821 
…izer() (python#161640)

Update also libregrtest.utils to detect function sanitizer
(-fsanitize=function).

(cherry picked from commit 4e10d4f)
@bedevere-app

bedevere-app Bot commented Nov 9, 2026

Copy link
Copy Markdown

GH-161713 is a backport of this pull request to the 3.15 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Nov 9, 2026
@vstinner vstinner removed the needs backport to 3.14 bugs and security fixes label Nov 9, 2026
vstinner added a commit that referenced this pull request Nov 10, 2026
@vstinner
[3.15] gh-111178: Set function=False by default in support.check_sani…
39d10e3 
…tizer() (#161640) (#161713)

gh-111178: Set function=False by default in support.check_sanitizer() (#161640)

Update also libregrtest.utils to detect function sanitizer
(-fsanitize=function).

(cherry picked from commit 4e10d4f)
@miss-islington miss-islington mentioned this pull request Nov 10, 2026
[3.14] gh-111178: Set function=False by default in support.check_sanitizer() (GH-161640) (GH-161713) #161720
Merged
vstinner added a commit that referenced this pull request Nov 10, 2026
@miss-islington @vstinner
[3.14] gh-111178: Set function=False by default in support.check_sani…
e3a433c 
…tizer() (GH-161640) (GH-161713) (#161720)

[3.15] gh-111178: Set function=False by default in support.check_sanitizer() (GH-161640) (GH-161713)

gh-111178: Set function=False by default in support.check_sanitizer() (GH-161640)

Update also libregrtest.utils to detect function sanitizer
(-fsanitize=function).
(cherry picked from commit 39d10e3)


(cherry picked from commit 4e10d4f)

Co-authored-by: Victor Stinner <[email protected]>
orsenthil pushed a commit to orsenthil/cpython that referenced this pull request Nov 12, 2026
@vstinner @orsenthil
pythongh-111178: Set function=False by default in support.check_sanit…
e7c0ee8 
…izer() (python#161640)

Update also libregrtest.utils to detect function sanitizer
(-fsanitize=function).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@vstinner vstinner

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.