GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-161827: Mark `_PyEval_EvalFrameDefault` as `Py_NO_INLINE` by ikrommyd · Pull Request #161829 · python/cpython

Conversation

@ikrommyd

@ikrommyd ikrommyd commented Nov 11, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

As discussed in #161827, with the tail-calling interpreter _PyEval_EvalFrameDefault can get inlined into its callers (e.g. with Clang PGO) and no longer appear in the native call stack. This marks it Py_NO_INLINE so tools that rely on finding it keep working.

  • Issue: _PyEval_EvalFrameDefault not in the call stack when interpreter is built with --with-tail-call-interp #161827

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ikrommyd
pythongh-161827: Mark _PyEval_EvalFrameDefault as Py_NO_INLINE
36383f6 
Signed-off-by: Iason Krommydas <[email protected]>
@ikrommyd
ikrommyd requested a review from markshannon as a code owner November 11, 2026 21:15
@python-cla-bot

python-cla-bot Bot commented Nov 11, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot mentioned this pull request Nov 11, 2026
_PyEval_EvalFrameDefault not in the call stack when interpreter is built with --with-tail-call-interp #161827
Open
@bedevere-app bedevere-app Bot added the awaiting review label Nov 11, 2026
Fidget-Spinner
Fidget-Spinner approved these changes Nov 11, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Nov 11, 2026
@Fidget-Spinner Fidget-Spinner added needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Nov 11, 2026
@Fidget-Spinner
Fidget-Spinner enabled auto-merge (squash) November 11, 2026 21:48
@Fidget-Spinner
Fidget-Spinner merged commit 043ddef into python:main Nov 11, 2026
69 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Nov 11, 2026

Copy link
Copy Markdown

Thanks @ikrommyd for the PR, and @Fidget-Spinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Nov 11, 2026
@bedevere-app

bedevere-app Bot commented Nov 11, 2026

Copy link
Copy Markdown

GH-161833 is a backport of this pull request to the 3.15 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Nov 11, 2026
@bedevere-app

bedevere-app Bot commented Nov 11, 2026

Copy link
Copy Markdown

GH-161834 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 11, 2026
@ikrommyd
ikrommyd deleted the gh-161827-noinline-evalframe branch November 11, 2026 22:10
orsenthil pushed a commit to orsenthil/cpython that referenced this pull request Nov 12, 2026
@ikrommyd @orsenthil
pythongh-161827: Mark _PyEval_EvalFrameDefault as Py_NO_INLINE (p…
1b49823 
…ythonGH-161829)

pythongh-161827: Mark _PyEval_EvalFrameDefault as Py_NO_INLINE

Signed-off-by: Iason Krommydas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ikrommyd @Fidget-Spinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.