GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix test_import assertions that never compared against the expected value by andresdelfino · Pull Request #161831 · python/cpython

Conversation

@andresdelfino

@andresdelfino andresdelfino commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

test_pyinit_function_raises_exception passed the expected value as the second argument of assertIsNotNone(), which is the failure message:

self.assertIsNotNone(exception.type.__name__, "ImportError")
self.assertIsNotNone(exception.msg, "failed to import from subinterpreter due to exception")

So the test only checked that the type name and message were not None, and never compared them with the intended values. This switches both to assertEqual(). The expected message matches the ImportError raised in Python/import.c (added in gh-144601).

Follow-up to #161774, which fixed the same mistake with assertTrue(). It was found the same way, by walking the AST of every tracked .py file for assert* calls whose msg argument isn't a string, then reviewing each hit by hand. The other hits either pass useful context (inputs, process output, etc.) or are harmless leftovers such as assertIsNone(x, None), so they are left alone.

Test-only change, so this should be fine for skip issue / skip news. Tested locally on Linux.

🤖 Generated with Claude Code

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@andresdelfino @claude
Fix test_import assertions that never compared against the expected v…
ef0ba24
…alue

test_pyinit_function_raises_exception called assertIsNotNone() with the
expected value as the second argument, which is the failure message, so
the exception's type name and message were never checked.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@andresdelfino
andresdelfino requested review from FFY00, brettcannon, ericsnowcurrently, ncoghlan and warsaw as code owners November 11, 2026 21:43
@bedevere-app bedevere-app Bot added the awaiting review label Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner
@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@andresdelfino
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.