GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||
GeezerVison is showing github.com — Fix test assertions that never compared against the expected value by andresdelfino · Pull Request #161774 · python/cpython Conversation
Contributor
They were found by walking the AST of every tracked Two of the corrected assertions would have failed as-is, because the expected value had gone stale:
In the ctypes tests the expected values were Test-only change, so this should be fine for 🤖 Generated with Claude Code
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsassertTrue(first, second) treats the second argument as the failure message, so these assertions only checked that the first argument was truthy. Use assertEqual() or assertIs() so the expected value is actually compared. Two of them were hiding stale expectations: * test_ssl.test_ecc_cert: since TLS 1.3 is negotiated, the cipher suite name no longer starts with "ECDHE-ECDSA". Only check it for TLS 1.2. * test_ttk_textonly.test_format_elemcreate: _format_elemcreate(None) returns ((),) since pythongh-68166 changed its return format. Co-Authored-By: Claude Opus 5.5 <[email protected]>
andresdelfino
requested review from
barneygale,
ethanfurman,
gpshead and
picnixz
as code owners
ethanfurman
approved these changes
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This now duplicates
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsUh oh!
There was an error while loading. Please reload this page.
StanFromIreland
approved these changes
StanFromIreland
enabled auto-merge (squash)
Uh oh!
There was an error while loading. Please reload this page.
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
StanFromIreland
added a commit
that referenced
this pull request
…alue (GH-161774) (#161823) (cherry picked from commit aecef70) Co-authored-by: Andrés Delfino <[email protected]> Co-authored-by: Stan Ulbrych <[email protected]>
StanFromIreland
added a commit
that referenced
this pull request
…alue (GH-161774) (#161824) (cherry picked from commit aecef70) Co-authored-by: Andrés Delfino <[email protected]> Co-authored-by: Stan Ulbrych <[email protected]>
This was referenced
orsenthil
pushed a commit
to orsenthil/cpython
that referenced
this pull request
…ython#161774) Co-authored-by: Stan Ulbrych <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabelsProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||||||||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |