GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix copy-pasted assert messages in test_crossinterp by andresdelfino · Pull Request #161835 · python/cpython

Conversation

@andresdelfino

@andresdelfino andresdelfino commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

In both test_module() methods (ShareableTypeTests and MarshalTests), the assertion for unittest reused the message from the line above it:

assert type(defs) is types.ModuleType, type(defs)
assert type(unittest) is types.ModuleType, type(defs)

So if unittest weren't a module, the failure would report the type of defs instead. This changes the message to type(unittest), matching the two lines before it.

Found while auditing test assertions for misused arguments (see #161774).

Test-only change, so this should be fine for skip issue / skip news. Tested locally on Linux; both test_module tests pass.

🤖 Generated with Claude Code

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@andresdelfino @claude
Fix copy-pasted assert messages in test_crossinterp
b450677 
Both test_module() methods checked type(unittest) but reported
type(defs) on failure.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@andresdelfino
andresdelfino requested a review from ericsnowcurrently as a code owner November 11, 2026 21:57
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting review labels Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@andresdelfino
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.