GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-38183: Test_idle ignores user config directory. by terryjreedy · Pull Request #16198 · python/cpython

Conversation

@terryjreedy

@terryjreedy terryjreedy commented Sep 16, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

It no longer tries to create or access .idlerc or any files within.
Users must run IDLE to discover problems with saving settings.

https://bugs.python.org/issue38183

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@terryjreedy
bpo-38183: Test-idle skips user config directory.
778fba1 
It no longer tries to create .idlerc or any files within.
Users must run IDLE to discover settings save problems.
@terryjreedy terryjreedy added tests Tests in the Lib/test dir needs backport to 3.7 labels Sep 16, 2019
@terryjreedy terryjreedy self-assigned this Sep 16, 2019
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 16, 2019
@bedevere-bot bedevere-bot added the awaiting core review label Sep 16, 2019
@terryjreedy
Don't write usercfg when testing, but do give testable names.
634ca2d 
Add a few other testing cleanups.
@terryjreedy

terryjreedy commented Sep 16, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Writing 'recent-files.lst' instead of "$HOME/.idlerc/recent-files.lst" resulted in a new ENV CHANGED failure -- on linux only.
@vstinner Is there documentation on what changes cause a failure?

New patch should prevent writing that file.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
terryjreedy added 4 commits September 16, 2019 17:43
@terryjreedy
Don't read/write recent-files.lst when no userdir.
d32b731
@terryjreedy
Add note in case add tests for breakpoints.
e8eab73
@terryjreedy
Update 2019-09-16-15-04-29.bpo-38183.eudCN1.rst
0d97eba
@terryjreedy
Update 2019-09-16-15-04-29.bpo-38183.eudCN1.rst
41e7677
@terryjreedy terryjreedy changed the title bpo-38183: Test-idle skips user config directory. bpo-38183: Test_idle skips user config directory. Sep 16, 2019
@terryjreedy terryjreedy changed the title bpo-38183: Test_idle skips user config directory. bpo-38183: Test_idle ignores user config directory. Sep 16, 2019
@terryjreedy
Update 2019-09-16-15-04-29.bpo-38183.eudCN1.rst
d8ae566
@terryjreedy
terryjreedy merged commit 0048afc into python:master Sep 16, 2019
@terryjreedy
terryjreedy deleted the bbtest branch September 16, 2019 23:04
@miss-islington

miss-islington commented Sep 16, 2019

Copy link
Copy Markdown
Contributor

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Sep 16, 2019
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 16, 2019
@terryjreedy @miss-islington
bpo-38183: Test_idle ignores user config directory pythonGH-16198)
4cf8ba5 
It no longer tries to create or access .idlerc or any files within.
Users must run IDLE to discover problems with saving settings.
(cherry picked from commit 0048afc)

Co-authored-by: Terry Jan Reedy <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 16, 2019
@terryjreedy @miss-islington
bpo-38183: Test_idle ignores user config directory pythonGH-16198)
af955eb 
It no longer tries to create or access .idlerc or any files within.
Users must run IDLE to discover problems with saving settings.
(cherry picked from commit 0048afc)

Co-authored-by: Terry Jan Reedy <[email protected]>
miss-islington added a commit that referenced this pull request Sep 17, 2019
@miss-islington @terryjreedy
bpo-38183: Test_idle ignores user config directory GH-16198)
ad845be 
It no longer tries to create or access .idlerc or any files within.
Users must run IDLE to discover problems with saving settings.
(cherry picked from commit 0048afc)

Co-authored-by: Terry Jan Reedy <[email protected]>
miss-islington added a commit that referenced this pull request Sep 17, 2019
@miss-islington @terryjreedy
bpo-38183: Test_idle ignores user config directory GH-16198)
523497c 
It no longer tries to create or access .idlerc or any files within.
Users must run IDLE to discover problems with saving settings.
(cherry picked from commit 0048afc)

Co-authored-by: Terry Jan Reedy <[email protected]>
@terryjreedy terryjreedy mentioned this pull request May 28, 2020
gh-82005: Properly handle user input warnings in IDLE shell. #15311
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@terryjreedy terryjreedy

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@terryjreedy @miss-islington @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.