GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-38238: site.py report user paths contingent on ENABLE_USER_SITE by bjmuld · Pull Request #16303 · python/cpython

Conversation

@bjmuld

@bjmuld bjmuld commented Sep 20, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

https://bugs.python.org/issue38238

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
miss-islington and others added 30 commits July 6, 2019 05:56
@miss-islington @taleinat
bpo-26806: add 30 to the recursion limit in IDLE's shell (GH-13944)
d666217
This is done to compensate for the extra stack frames added by
IDLE itself, which cause problems when setting the recursion limit
to low values.

This wraps sys.setrecursionlimit() and sys.getrecursionlimit()
as invisibly as possible.
(cherry picked from commit fcf1d00)

Co-authored-by: Tal Einat <[email protected]>
@miss-islington @terryjreedy
bpo-37487: Fix PyList_GetItem index description. (GH-14623) (GH-14625)
9c930d0
0 is a legal index.
(cherry picked from commit f8709e8)

Co-authored-by: Terry Jan Reedy <[email protected]>
@miss-islington @aeros @terryjreedy
bpo-37478: Specify possible exceptions for os.chdir() (GH-14611) (GH-…
1dd6507
…14630)

(cherry picked from commit 0717b4d)

Co-authored-by: Kyle Stanley <[email protected]>
@miss-islington @terryjreedy
bpo-37478: Add missing 'and'. (GH-14631)
e841a54
(cherry picked from commit a9b40e4)

Co-authored-by: Terry Jan Reedy <[email protected]>
@miss-islington @shihai1991
bpo-37513: Change ValueError to TypeError in an example in ctypes doc (…
bc0a6ce
…GH-14615)

(cherry picked from commit f6cdd3f)

Co-authored-by: Hai Shi <[email protected]>
@pablogsal @ned-deily
[3.7] bpo-37500: Revert commit 85ed171 (GH-14605)
4834c80
https://bugs.python.org/issue37500
@ned-deily
[3.7] bpo-37500: update Misc/NEWS entries to mention revert
87a918a
@miss-islington @terryjreedy @ned-deily
bpo-37149: Replace dead link for online Tkinter reference (GH-14616)
f2cbf41
Also fix a name misspelling.
(cherry picked from commit 45bc61b)

Co-authored-by: Terry Jan Reedy <[email protected]>
@ned-deily
3.7.4 final
e093591
@miss-islington @JulienPalard
Doc: Fix: Proper UpperCamelCase and lowercase. (GH-14644)
6f55748
Initial report by Michael Blankenship on docs@
(cherry picked from commit 2da622f)

Co-authored-by: Julien Palard <[email protected]>
@miss-islington @JulienPalard
Doc: Fix example title. (GH-14639)
8b1135f
(cherry picked from commit 66b4150)

Co-authored-by: Julien Palard <[email protected]>
@ned-deily
Merge release engineering branch
d9012d6
@ned-deily
Post release updates
4016cd5
@miss-islington @terryjreedy
bpo-26806: IDLE should run without docstrings (GH-14657) (GH-14678)
f54f062
After fcf1d00, IDLE startup failed with python compiled without docstrings.
(cherry picked from commit 6aeb2fe)

Co-authored-by: Terry Jan Reedy <[email protected]>
@miss-islington @benjaminp
Document default parameter of .seek() in the signature. (GH-14691)
2847a75
(cherry picked from commit 2a3d4d9)

Co-authored-by: Benjamin Peterson <[email protected]>
@miss-islington @taleinat
bpo-34369: make kqueue.control() docs better reflect that timeout is …
d3747fd
…positional-only (GH-9499)

(cherry picked from commit 79042ac)

Co-authored-by: Tal Einat <[email protected]>
@miss-islington @taleinat
bpo-36390: simplify classifyws(), rename it and add unit tests (GH-14500
a2cf88e
)

(cherry picked from commit 9b5ce62)

Co-authored-by: Tal Einat <[email protected]>
@miss-islington @Mariatta
closes bpo-37554: Remove q:q in os.rst documentation (GH-14692)
71435f6
https://bugs.python.org/issue37554
(cherry picked from commit 7cbef72)

Co-authored-by: Mariatta <[email protected]>
@miss-islington @rdipietro
Fix typo in re.escape documentation (GH-14722)
184d06b
(cherry picked from commit fb6c1f8)

Co-authored-by: Robert DiPietro <[email protected]>
@miss-islington @zvyn
bpo-37580: Fix typo in http.cookiejar documentation (GH-14731)
36494a9
[bpo-37580](https://bugs.python.org/issue37580): Markup typo in http.cookiejar doc

https://bugs.python.org/issue37580
(cherry picked from commit b5bbb8a)

Co-authored-by: Milan Oberkirch <[email protected]>
@miss-islington @webknjaz
bpo-30088: Document that existing dir structure isn't verified by mai…
d152414
…lbox.Maildir (GH-1163)

Hi,

I've faced an issue w/ `mailbox.Maildir()`. The case is following:
1. I create a folder with `tempfile.TemporaryDirectory()`, so it's empty
2. I pass that folder path as an argument when instantiating `mailbox.Maildir()`
3. Then I receive an exception happening because "there's no such file or directory" (namely `cur`, `tmp` or `new`) during interaction with Maildir

**Expected result:** subdirs are created during `Maildir()` instance creation.

**Actual result:** subdirs are assumed as existing which leads to exceptions during use.

**Workaround:** remove the actual dir before passing the path to `Maildir()`. It will be created automatically with all subdirs needed.

**Fix:** This PR. Basically it adds creation of subdirs regardless of whether the base dir existed before.

https://bugs.python.org/issue30088
(cherry picked from commit e441847)

Co-authored-by: Sviatoslav Sydorenko <[email protected]>
@miss-islington @carlbordum
bpo-36261: Improve example of the preamble field in email docs (GH-14751
fb58024
)

(cherry picked from commit 8efade9)

Co-authored-by: Carl Bordum Hansen <[email protected]>
@miss-islington @mangrisano
bpo-37571: Add 'b' to prevent the TypeError exception. (GH-14721)
d7caf75
Co-Authored-By: Kyle Stanley <[email protected]>
(cherry picked from commit 6b92958)

Co-authored-by: Michele Angrisano <[email protected]>
@miss-islington @zooba
bpo-37571: Remove extra space in ctypes docs (GH14764)
13c89f3
(cherry picked from commit 68c74d0)

Co-authored-by: Steve Dower <[email protected]>
@miss-islington @cstyles
Clarify that plistlib's load and dump functions take a binary file ob…
5631e38
…ject (GH-9825)

The documentation says that the fp parameter to plistlib.load "should be a
readable and binary file object" but the docstring only mentions that it
should be readable. Similarly, plistlib.dump's docstring only mentions
"writable". This commit clarifies that fp should also be binary.

https://docs.python.org/3/library/plistlib.htmlGH-plistlib.load
https://docs.python.org/3/library/plistlib.htmlGH-plistlib.dump
(cherry picked from commit 0d4f435)

Co-authored-by: Collin Styles <[email protected]>
@tirkarthi @miss-islington
[3.7] bpo-37579: Improve equality behavior for pure Python datetime a…
c6b3106
…nd time (GH-14726) (GH-14745)

Returns NotImplemented for timedelta and time in __eq__ for different types in Python implementation, which matches the C implementation.

This also adds tests to enforce that these objects will fall back to the right hand side's __eq__ and/or __ne__ implementation.

[bpo-37579](https://bugs.python.org/issue37579)
(cherry picked from commit e6b46aa)

Co-authored-by: Xtreak <[email protected]>





https://bugs.python.org/issue37579
@miss-islington @potomak
bpo-37284: Add note to sys.implementation doc (GH-14328)
134f796
Add a brief note to indicate that any new required attributes must go through the PEP process.

https://bugs.python.org/issue37284
(cherry picked from commit 52693c1)

Co-authored-by: Giovanni Cappellotto <[email protected]>
@miss-islington @pganssle
Fix infinite loop in email folding logic (GH-12732)
e7bec26
As far as I can tell, this infinite loop would be triggered if:

1. The value being folded contains a single word (no spaces) longer than
   max_line_length
2. The max_line_length is shorter than the encoding's name + 9
   characters.

bpo-36564: https://bugs.python.org/issue36564
(cherry picked from commit f69d5c6)

Co-authored-by: Paul Ganssle <[email protected]>
@miss-islington @csabella @terryjreedy
bpo-27452: IDLE: Cleanup config.py code (GH-14577) (GH-14803)
efd23a1
(cherry picked from commit f8d4cc7)

Co-authored-by: Cheryl Sabella <[email protected]>
@miss-islington @madphysicist
Docs: Correct formatting of a multiline code block (GH-13806)
ba3c89f
(cherry picked from commit bd26a44)

Co-authored-by: Joseph Fox-Rabinovitz <[email protected]>
miss-islington and others added 18 commits September 16, 2019 20:33
@miss-islington @terryjreedy
bpo-38183: Test_idle ignores user config directory GH-16198)
523497c
It no longer tries to create or access .idlerc or any files within.
Users must run IDLE to discover problems with saving settings.
(cherry picked from commit 0048afc)

Co-authored-by: Terry Jan Reedy <[email protected]>
@miss-islington @adorilson @matrixise
Doc: Add list(dict) in stdtypes library (GH-16209) (GH-16211)
89f132a
(cherry picked from commit 63dedef)

Co-authored-by: Adorilson Bezerra <[email protected]>
@miss-islington @serhiy-storchaka
bpo-38175: Fix a memory leak in comparison of sqlite3.Row objects. (G…
4ac1be2
…H-16155)

(cherry picked from commit 8debfa5)

Co-authored-by: Serhiy Storchaka <[email protected]>
@miss-islington @terryjreedy
bpo-35379: When exiting IDLE, catch any AttributeError. (GH-16212)
3d916a7
One happens when EditorWindow.close is called twice.
Printing a traceback, when IDLE is run from a terminal,
is useless and annoying.
(cherry picked from commit dfd34a9)

Co-authored-by: Terry Jan Reedy <[email protected]>
@miss-islington @serhiy-storchaka
bpo-38185: Fixed case-insensitive string comparison in sqlite3.Row in…
80cb055
…dexing. (GH-16190)

(cherry picked from commit f669581)

Co-authored-by: Serhiy Storchaka <[email protected]>
@miss-islington @hniksic
bpo-38192: Fix remaining passing of "loop" in the protocol examples (G…
facbd31
…H-16202)

See https://bugs.python.org/issue38192 .

https://bugs.python.org/issue38192
(cherry picked from commit 5d359cc)

Co-authored-by: Hrvoje Nikšić <[email protected]>
@miss-islington @joernheissler
Doc: Fix grammar/spelling in ssl.VERIFY_CRL_CHECK_LEAF docs (GH-16221)
6422392
(cherry picked from commit 219fb9d)

Co-authored-by: Jörn Heissler <[email protected]>
@miss-islington @vstinner
bpo-37531: regrtest main process uses shorter timeout (GH-16220) (GH-…
6591b4b
…16223)

When using multiprocesss (-jN), the main process now uses a timeout
of 60 seconds instead of the double of the --timeout value. The
buildbot server stops a job which does not produce any output in 1200
seconds.
(cherry picked from commit 46b0b81)

Co-authored-by: Victor Stinner <[email protected]>
@miss-islington @asvetlov
bpo-38013: make async_generator_athrow object tolerant to throwing ex…
fc022f0
…ceptions (GH-16070)

Even when the helper is not started yet.

This behavior follows conventional generator one.
There is no reason for `async_generator_athrow` to handle `gen.throw()` differently.

https://bugs.python.org/issue38013
(cherry picked from commit c275312)

Co-authored-by: Andrew Svetlov <[email protected]>
@serhiy-storchaka
[3.7] bpo-38191: Accept arbitrary keyword names in NamedTuple(). (GH-…
69b3718
…16222) (GH-16239)

This includes such names as "cls", "self", "typename" and "fields".
(cherry picked from commit 2bf31cc)
@miss-islington Diego Alberto Barriga Martínez @ericvsmith
bpo-37904: Edition on python tutorial - section 4 (GH-16169) (GH-16235)
8b907a8
A little change on first paragraph of python tutorial to be more clearly

https://bugs.python.org/issue37904

Automerge-Triggered-By: @ericvsmith
(cherry picked from commit b574813)

Co-authored-by: Diego Alberto Barriga Martínez <[email protected]>
@miss-islington @vstinner
bpo-38203: faulthandler.dump_traceback_later() is always available (G…
1a3a48d
…H-16260)

dump_traceback_later() and cancel_dump_traceback_later() functions of
the faulthandler module are always available since Python 3.7.
(cherry picked from commit 064e1e3)

Co-authored-by: Victor Stinner <[email protected]>
@miss-islington @pluradj-ibm @matrixise
[3.7] bpo-38218: Doc: Corrected syntax for return annotation (GH-16265)…
20d3bce
… (GH-16275)

Signed-off-by: Jason Plurad <[email protected]>
(cherry picked from commit 9ab6038)

Co-authored-by: Jason Plurad <[email protected]>
@miss-islington @toonarmycaptain
Doc: Clarify dict equality irrespective of ordering. (GH-16266)
50ecedc
(cherry picked from commit 3171d67)

Co-authored-by: toonarmycaptain <[email protected]>
@vstinner
bpo-37531: sync regrtest with master branch (GH-16285) (GH-16289)
5e1400a
(cherry picked from commit fb7746d)
@miss-islington @Kriyszig
bpo-37353: Updated parser note about source code compatibility(GH-14277)
2552e27
(cherry picked from commit 062cfe3)

Co-authored-by: Prateek Nayak <[email protected]>
@miss-islington @cool-RR
bpo-37937: Mention frame.f_trace in sys.settrace docs (GH-15439)
fd4f28d
Mention frame.f_trace in sys.settrace docs, as well as the fact you still
need to call `sys.settrace` to enable the tracing machinery before setting
`frame.f_trace` will have any effect.
(cherry picked from commit 9c2682e)

Co-authored-by: Ram Rachum <[email protected]>
@bjmuld
getuserbase() and getusersitepackages() respect ENABLE_USER_SITE
96f6657
@the-knights-who-say-ni

the-knights-who-say-ni commented Sep 20, 2019

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@bjmuld

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Sep 20, 2019
@bedevere-bot bedevere-bot added the awaiting review label Sep 20, 2019
@bjmuld
Update site.py
be3c99b
return empty string rather than None
@the-knights-who-say-ni the-knights-who-say-ni added CLA signed and removed CLA not signed labels Sep 20, 2019
@bjmuld
bjmuld changed the base branch from 3.7 to 3.8 September 20, 2019 20:10
@bjmuld
bjmuld changed the base branch from 3.8 to master September 20, 2019 20:11
@tiran tiran added the invalid label Sep 23, 2019
@tiran

tiran commented Sep 23, 2019

Copy link
Copy Markdown
Member

Thanks! However I'm closing the PR because

  1. The request on bugs.python.org breaks an existing stable API.
  2. It's an invalid PR with over 2000 commits from other people and lots of merge conflicts.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tiran tiran closed this Sep 23, 2019
@bjmuld bjmuld mannequin mentioned this pull request Feb 26, 2023
site.py reporting user site info even if ENABLE_USER_SITE=False #82419
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

18 participants

@bjmuld @the-knights-who-say-ni @tiran @asvetlov @carismoses @bedevere-bot @miss-islington @pablogsal @ned-deily @tirkarthi @aeros @taleinat @terryjreedy @serhiy-storchaka @keysmashes @shihai1991 @vstinner @pganssle
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.