GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-38360: macOS: support alternate form of -isysroot flag by jmroot · Pull Request #16480 · python/cpython

Conversation

jmroot commented Sep 30, 2019 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

It is possible to use either '-isysroot /some/path' or
'-isysroot/some/path' (no space in between). Support both forms in
places where special handling of -isysroot is done, rather than just
the first form.

https://bugs.python.org/issue38360

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

jmroot requested a review from a team as a code owner

September 30, 2019 00:42

the-knights-who-say-ni commented Sep 30, 2019

Copy link

Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@jmroot

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

the-knights-who-say-ni added the CLA not signed label

Sep 30, 2019

bedevere-bot added the awaiting review label

Sep 30, 2019

jmroot force-pushed the isysroot-fix branch from 756fbd8 to ddfb5b5 Compare

September 30, 2019 09:06

the-knights-who-say-ni added CLA signed and removed CLA not signed labels

Sep 30, 2019

jmroot commented Oct 3, 2019

Copy link

Copy Markdown

Contributor Author

https://bugs.python.org/issue38360

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jmroot changed the title ~~macOS: support alternate form of -isysroot flag~~ bpo-38360: macOS: support alternate form of -isysroot flag

Oct 19, 2019

jmroot force-pushed the isysroot-fix branch from ddfb5b5 to 9c9015e Compare

October 20, 2019 13:50


          bpo-38360: macOS: support alternate form of -isysroot flag (pythonGH-…

c76b8a2

…16480)

It is possible to use either '-isysroot /some/path' (with a space) or
'-isysroot/some/path' (no space in between). Support both forms in
places where special handling of -isysroot is done, rather than just
the first form.

jmroot force-pushed the isysroot-fix branch from 9c9015e to c76b8a2 Compare

November 8, 2019 10:45

ned-deily commented Nov 19, 2019

Copy link

Copy Markdown

Member

(Ack)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jmroot commented Feb 27, 2020

Copy link

Copy Markdown

Contributor Author

@ned-deily Ping. It would be nice to get this in to the 3.9.0 alphas.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ned-deily added 3 commits

April 22, 2020 03:13


          add some tests for alternate -isysroot

91dc76c


          add NEWS entry

b49f302


          use startswith() rather than find() == 0

cfa98fa

ned-deily approved these changes

Apr 22, 2020

View reviewed changes

ned-deily left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jmroot, for the nice PR. Few are brave enough to enter those waters. In the interests of time, I took the liberty of pushing a few changes into the PR, namely extending a couple of existing test cases to cover the singe-argument case and a minor style nit.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jmroot reacted with thumbs up emoji

All reactions

👍 1 reaction

bedevere-bot added awaiting merge and removed awaiting review labels

Apr 22, 2020

ned-deily merged commit b310700 into python:master

Apr 22, 2020

bedevere-bot removed the awaiting merge label

Apr 22, 2020

jmroot deleted the isysroot-fix branch

April 22, 2020 11:21

ned-deily added needs backport to 3.7 labels

Apr 22, 2020

miss-islington commented Apr 22, 2020

Copy link

Copy Markdown

Contributor

Thanks @jmroot for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington commented Apr 22, 2020

Copy link

Copy Markdown

Contributor

Thanks @jmroot for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Apr 22, 2020


          bpo-38360: macOS: support alternate form of -isysroot flag (pythonGH-…

48128c6

…16480)

It is possible to use either '-isysroot /some/path' (with a space) or
'-isysroot/some/path' (no space in between). Support both forms in
places where special handling of -isysroot is done, rather than just
the first form.
Co-authored-by: Ned Deily <[email protected]>
(cherry picked from commit b310700)

Co-authored-by: Joshua Root <[email protected]>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Apr 22, 2020


          bpo-38360: macOS: support alternate form of -isysroot flag (pythonGH-…

05645b0

…16480)

It is possible to use either '-isysroot /some/path' (with a space) or
'-isysroot/some/path' (no space in between). Support both forms in
places where special handling of -isysroot is done, rather than just
the first form.
Co-authored-by: Ned Deily <[email protected]>
(cherry picked from commit b310700)

Co-authored-by: Joshua Root <[email protected]>

bedevere-bot removed the needs backport to 3.8 label

Apr 22, 2020

bedevere-bot commented Apr 22, 2020

Copy link

Copy Markdown

GH-19658 is a backport of this pull request to the 3.8 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.7 label

Apr 22, 2020

bedevere-bot commented Apr 22, 2020

Copy link

Copy Markdown

GH-19657 is a backport of this pull request to the 3.7 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington added a commit that referenced this pull request

Apr 22, 2020


          bpo-38360: macOS: support alternate form of -isysroot flag (GH-16480)

e7f8684

It is possible to use either '-isysroot /some/path' (with a space) or
'-isysroot/some/path' (no space in between). Support both forms in
places where special handling of -isysroot is done, rather than just
the first form.
Co-authored-by: Ned Deily <[email protected]>
(cherry picked from commit b310700)

Co-authored-by: Joshua Root <[email protected]>

miss-islington added a commit that referenced this pull request

Apr 22, 2020


          bpo-38360: macOS: support alternate form of -isysroot flag (GH-16480)

4a6da0b

It is possible to use either '-isysroot /some/path' (with a space) or
'-isysroot/some/path' (no space in between). Support both forms in
places where special handling of -isysroot is done, rather than just
the first form.
Co-authored-by: Ned Deily <[email protected]>
(cherry picked from commit b310700)

Co-authored-by: Joshua Root <[email protected]>

Reviewers

ned-deily

ned-deily approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

jmroot commented Sep 30, 2019 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

the-knights-who-say-ni commented Sep 30, 2019

CLA Missing

Uh oh!

jmroot commented Oct 3, 2019

Uh oh!

ned-deily commented Nov 19, 2019

Uh oh!

jmroot commented Feb 27, 2020

Uh oh!

ned-deily left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington commented Apr 22, 2020

Uh oh!

miss-islington commented Apr 22, 2020

Uh oh!

bedevere-bot commented Apr 22, 2020

Uh oh!

bedevere-bot commented Apr 22, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jmroot commented Sep 30, 2019 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.