GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-29520: Fix deprecation warning from 'defindex' template by methane · Pull Request #165 · python/cpython

Conversation

@methane

@methane methane commented Feb 19, 2017

Copy link
Copy Markdown
Member

Confirmed with Sphinx 1.3.6 and 1.5.2
[bpo-29520]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@methane methane added docs Documentation in the Doc dir needs backport to 2.7 labels Feb 19, 2017
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 19, 2017
@methane
bpo-29520: Fix deprecation warning from 'defindex' template
1dbe103
@methane
methane force-pushed the support-new-sphinx branch from d8de985 to 1dbe103 Compare February 19, 2017 04:32
@methane methane mentioned this pull request Feb 19, 2017
bpo-29520: Fixing deprecation warning while building docs #170
Closed
methane
methane commented Feb 19, 2017
View reviewed changes
Comment thread Doc/tools/templates/indexcontent.html
<h1>{{ docstitle|e }}</h1>
<p>
{% trans %}Welcome! This is the documentation for Python {{ release }}{% endtrans %}
</p>

@methane methane Feb 19, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this paragraph is redundant. But it's out of scope of the issue.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@methane methane Feb 19, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are minor change. ", last updated Feb 19, 2017." part is removed.
I remove it because "Last update: " is in footer. It's duplicated information.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ncoghlan

ncoghlan commented Feb 19, 2017

Copy link
Copy Markdown
Contributor

I think the main advantage I see to @ultimatecoder's approach in #170 is that that doesn't require changing the minimum Sphinx version.

Perhaps it would make sense to go with this PR and the newer Sphinx requirement for 3.7+, while using the approach in #170 for the maintenance branches?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
berkerpeksag
berkerpeksag approved these changes Feb 19, 2017
View reviewed changes

@berkerpeksag berkerpeksag left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I prefer this over #170. defindex comes from the very early days of Sphinx (pre 1.0 IIRC) and it was kept for backward compatibility reasons over the years. Since it's easy to drop it I don't think we should maintain a copy of defindex.html in CPython codebase.

And since we use venv to build the docs it's easy to upgrade the Sphinx version installed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@methane

methane commented Feb 19, 2017

Copy link
Copy Markdown
Member Author

@ncoghlan I update minimum version because no one test it.
I don't think this change require updating minimum version.

sphinx-doc/sphinx#2986 (comment)

It was used to keep compatibility to before Sphinx-0.2.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@methane

methane commented Feb 19, 2017

Copy link
Copy Markdown
Member Author

I confirmed sphinx 1.2.3 can build html without any warnings.
Should I revert 'minimum version'? (approval is required again)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@berkerpeksag

berkerpeksag commented Feb 19, 2017

Copy link
Copy Markdown
Member

That's great! Assuming you've also verified the HTML output of indexcontent.html, count me as +1 on keeping the minimum Sphinx version as 1.2.

Thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@methane
revert minimum sphinx version to 1.2
8ea989f
@methane
methane merged commit 3eea8c6 into python:master Feb 19, 2017
@methane
methane deleted the support-new-sphinx branch February 19, 2017 17:07
This was referenced Feb 19, 2017
[3.6] bpo-29520: fix deprecation warning from 'defindex' template #178
Merged
[3.5] bpo-29520: fix deprecation warning from 'defindex' template #179
Merged
[2.7] bpo-29520: fix deprecation warning from 'defindex' template #180
Merged
methane added a commit to methane/cpython that referenced this pull request Feb 20, 2017
@methane
bpo-29520: doc: fix deprecation warning from 'defindex' template (pyt…
dbe3f9c 
…honGH-165)
methane added a commit to methane/cpython that referenced this pull request Feb 20, 2017
@methane
bpo-29520: doc: fix deprecation warning from 'defindex' template (pyt…
76d0b43 
…honGH-165)
methane added a commit to methane/cpython that referenced this pull request Feb 20, 2017
@methane
bpo-29520: doc: fix deprecation warning from 'defindex' template (pyt…
a8aedaf 
…honGH-165)
@Mariatta Mariatta removed needs backport to 2.7 labels Feb 22, 2017
isidentical added a commit to isidentical/cpython that referenced this pull request Oct 25, 2021
@isidentical
allow multiline debug expresisons (python#165)
81ed1ec 
* allow multiline debug expresisons

* check whether the bracket is top-level

* fix punctuation to top-level :

* inline f-string level check to callsites

* free fstring buffers at the end#

* fix leaked buffer on realloc#
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@methane @ncoghlan @berkerpeksag @Mariatta @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.