GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-26103: Update the description of isdatadescriptor in inspect.rst by hongweipeng · Pull Request #16645 · python/cpython

Conversation

@hongweipeng

@hongweipeng hongweipeng commented Oct 8, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This is a complement to that PR #1959 . That PR may have forgotten to update the inspect.rst file.

https://bugs.python.org/issue26103

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hongweipeng
Fix the description of isdatadescriptor in inspect.rst
616db39
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Oct 8, 2019
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 8, 2019
tirkarthi
tirkarthi approved these changes Oct 9, 2019
View reviewed changes

@tirkarthi tirkarthi left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as per linked PR and the implementation

cpython/Lib/inspect.py

Line 122 in ecbf35f

return hasattr(tp, "__set__") or hasattr(tp, "__delete__")
. Thanks.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Oct 9, 2019
@brandtbucher brandtbucher added skip news needs backport to 3.8 labels Oct 9, 2019
brandtbucher
brandtbucher approved these changes Oct 9, 2019
View reviewed changes
taleinat
taleinat approved these changes Nov 15, 2019
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Nov 15, 2019
@taleinat
taleinat merged commit 84f2528 into python:master Nov 15, 2019
@bedevere-bot

bedevere-bot commented Nov 15, 2019

Copy link
Copy Markdown

@taleinat: Please replace # with GH- in the commit message next time. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Nov 15, 2019

Copy link
Copy Markdown
Contributor

Thanks @hongweipeng for the PR, and @taleinat for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 15, 2019
@bedevere-bot

bedevere-bot commented Nov 15, 2019

Copy link
Copy Markdown

GH-17180 is a backport of this pull request to the 3.8 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Nov 15, 2019
miss-islington added a commit that referenced this pull request Nov 15, 2019
@miss-islington @hongweipeng
Fix the description of isdatadescriptor in inspect.rst (GH-16645)
0b634df 
(cherry picked from commit 84f2528)

Co-authored-by: HongWeipeng <[email protected]>
@hongweipeng
hongweipeng deleted the doc_inspect_isdatadescriptor branch November 16, 2019 00:48
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@hongweipeng Jake Taylor
Fix the description of isdatadescriptor in inspect.rst (python#16645)
af787fe
@hongweipeng
hongweipeng restored the doc_inspect_isdatadescriptor branch December 6, 2019 09:46
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@hongweipeng @shihai1991
Fix the description of isdatadescriptor in inspect.rst (python#16645)
6538a28
@hongweipeng
hongweipeng deleted the doc_inspect_isdatadescriptor branch December 5, 2021 14:47
@aaronchall aaronchall mannequin mentioned this pull request Apr 6, 2023
Contradiction in definition of "data descriptor" between (dotted lookup behavior/datamodel documentation) and (inspect lib/descriptor how-to) #70291
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirkarthi tirkarthi tirkarthi approved these changes
@brandtbucher brandtbucher brandtbucher approved these changes
+1 more reviewer
@taleinat taleinat taleinat approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@hongweipeng @bedevere-bot @miss-islington @taleinat @tirkarthi @brandtbucher @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.