GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-29592: site: skip abs_paths() when it's redundant by methane · Pull Request #167 · python/cpython

Conversation

@methane

@methane methane commented Feb 19, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

[bpo-29592]
os.path.abspath() is relatively slow function. Let's skip it if possible.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@methane
bpo-29592: remove abs_paths() from site.py
1b3dfe6 
It seems redundant for now.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 19, 2017
@methane methane added the performance Performance or resource usage label Feb 19, 2017
@methane
Call abs_paths() only if removeduppaths() changed sys.path
3632140
@methane
methane force-pushed the faster-site2 branch from 618751a to 3632140 Compare February 19, 2017 14:20
@methane methane changed the title bpo-29592: remove abs_paths() from site.py bpo-29592: site: skip abs_paths() when it's redundant Feb 19, 2017
@methane

methane commented Mar 14, 2017

Copy link
Copy Markdown
Member Author

@ncoghlan Would you see this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ncoghlan
ncoghlan approved these changes Mar 14, 2017
View reviewed changes

@ncoghlan ncoghlan left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@methane
methane merged commit 2e4e011 into python:master Mar 14, 2017
@methane
methane deleted the faster-site2 branch March 14, 2017 15:52
@methane methane mentioned this pull request Jun 28, 2017
bpo-29585: optimize site.py startup time #136
Merged
akruis added a commit to akruis/cpython that referenced this pull request Aug 16, 2018
@akruis
Stackless issue python#167: replace printf() by PySys_WriteStderr()
8a44a5f 
printf() was used to emit parts of an error message, if there is a
pending error while entering Stackless subsystem.
akruis added a commit to akruis/cpython that referenced this pull request Aug 16, 2018
@akruis
Stackless issue python#167: replace printf() by PySys_WriteStderr()
ef448f3 
printf() was used to emit parts of an error message, if there is a
pending error while entering Stackless subsystem.
(cherry picked from commit 8a44a5f)
akruis added a commit to akruis/cpython that referenced this pull request Sep 11, 2018
@akruis
Stackless issue python#167: replace printf() by PySys_WriteStderr()
85dbd4b 
printf() was used to emit parts of an error message, if there is a
pending error while entering Stackless subsystem.
(cherry picked from commit 8a44a5f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncoghlan ncoghlan ncoghlan approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

performance Performance or resource usage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@methane @ncoghlan @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.