GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-36876: Re-organize the c-analyzer tool code. by ericsnowcurrently · Pull Request #16841 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Oct 18, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is partly a cleanup of the code. It also is preparation for getting the variables from the source (cross-platform) rather than from the symbols.

The change only touches the tool (and its tests).

https://bugs.python.org/issue36876

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ericsnowcurrently added 23 commits September 27, 2019 11:59
@ericsnowcurrently
Move show.py to c_analyzer_common.
8ce7d62
@ericsnowcurrently
Small cleanups around _check_results().
c40c247
@ericsnowcurrently
Merge c_parser.info into c_analyzer_common.info.
bf3bd21
@ericsnowcurrently
c_symbols.binary -> c_symbols.find.
52113ae
@ericsnowcurrently
Add ID.match().
dc8333f
@ericsnowcurrently
Add known.look_up_variable().
9b47596
@ericsnowcurrently
Add c_parser.find module.
67eea78
@ericsnowcurrently
Add c_symbols.find module.
b61b704
@ericsnowcurrently
Avoid variable resolution in _nm.iter_symbols().
a041e4a
@ericsnowcurrently
Add c_analyzer_common.find module.
b9b0499
@ericsnowcurrently
Use the new modules in __main__.
15b60db
@ericsnowcurrently
Drop the old code.
2f9958f
@ericsnowcurrently
Specify "preprocessed" option as an arg.
b05272c
@ericsnowcurrently
Add a TODO.
80d299c
@ericsnowcurrently
Use declarations.iter_all() instead of iter_variables().
15c1226
@ericsnowcurrently
Make sure "resolve()" is used properly.
e08bad5
@ericsnowcurrently
Move extract_storage() to c_parser.declarations.
fa6f1b5
@ericsnowcurrently
Move the generic code under a top-level c_analyzer package.
6531014
@ericsnowcurrently
Move some code to a new c_analyzer.variables package.
15f010b
@ericsnowcurrently
c_global -> cpython.
c399dc0
@ericsnowcurrently
Do not use Variable in symbols or parser packages.
025e8c3
@ericsnowcurrently
Drop "INCLUDES" from SOURCE_DIRS.
f60551e
@ericsnowcurrently
Process files more cleanly.
4beba49
@ericsnowcurrently ericsnowcurrently added the skip news label Oct 18, 2019
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Oct 18, 2019
@bedevere-bot bedevere-bot added the awaiting core review label Oct 18, 2019
ericsnowcurrently added 4 commits October 18, 2019 15:28
@ericsnowcurrently
Fix a typo.
9e5c09b
@ericsnowcurrently
Call check_filename() properly.
6e14276
@ericsnowcurrently
Fix one last import.
0ce0cd1
@ericsnowcurrently
Fix whitespace.
264d698
@ericsnowcurrently
ericsnowcurrently merged commit e4c431e into python:master Oct 19, 2019
@ericsnowcurrently
ericsnowcurrently deleted the c-globals-simplify branch October 19, 2019 02:00
@bedevere-bot bedevere-bot removed the awaiting core review label Oct 19, 2019
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@ericsnowcurrently Jake Taylor
bpo-36876: Re-organize the c-analyzer tool code. (pythongh-16841)
699e216 
This is partly a cleanup of the code. It also is preparation for getting the variables from the source (cross-platform) rather than from the symbols.

The change only touches the tool (and its tests).
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@ericsnowcurrently @shihai1991
bpo-36876: Re-organize the c-analyzer tool code. (pythongh-16841)
6c298c4 
This is partly a cleanup of the code. It also is preparation for getting the variables from the source (cross-platform) rather than from the symbols.

The change only touches the tool (and its tests).
@ericsnowcurrently ericsnowcurrently mentioned this pull request Apr 10, 2022
[subinterpreters] Global C variables are a problem #81057
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ericsnowcurrently @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.