GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Adding missing acknowledgement by Kentzo · Pull Request #17130 · python/cpython

Conversation

@Kentzo

@Kentzo Kentzo commented Nov 12, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Due to:
[bpo-26467](#9296): large chunk of the "based on" Apache 2.0 licensed code
[bpo-29302](#4790)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Kentzo
Missing ack
387ffc7 
bpo-26467: large chunk of the "based on" code
bpo-29302
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 12, 2019
@bedevere-bot bedevere-bot added the awaiting review label Nov 12, 2019
@brandtbucher brandtbucher added skip issue skip news docs Documentation in the Doc dir labels Nov 12, 2019
brandtbucher
brandtbucher approved these changes Nov 12, 2019
View reviewed changes

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Kentzo reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Nov 12, 2019
@benjaminp benjaminp added the needs backport to 3.8 label Nov 13, 2019
@benjaminp
benjaminp merged commit d6d6e2a into python:master Nov 13, 2019
@miss-islington

miss-islington commented Nov 13, 2019

Copy link
Copy Markdown
Contributor

Thanks @Kentzo for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed awaiting core review needs backport to 3.8 labels Nov 13, 2019
@bedevere-bot

bedevere-bot commented Nov 13, 2019

Copy link
Copy Markdown

GH-17138 is a backport of this pull request to the 3.8 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington added a commit that referenced this pull request Nov 13, 2019
@miss-islington @Kentzo
Add Ilya Kulakov to Misc/ACKS. (GH-17130)
e5125f7 
Contributions on bpo-26467 and bpo-29302.
(cherry picked from commit d6d6e2a)

Co-authored-by: Ilya Kulakov <[email protected]>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@Kentzo Jake Taylor
Add Ilya Kulakov to Misc/ACKS. (pythonGH-17130)
9844b12 
Contributions on bpo-26467 and bpo-29302.
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@Kentzo @shihai1991
Add Ilya Kulakov to Misc/ACKS. (pythonGH-17130)
39c406a 
Contributions on bpo-26467 and bpo-29302.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Kentzo @miss-islington @bedevere-bot @brandtbucher @benjaminp @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.