GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [WIP] gh-82987: bdb: stop_here: always stop at calling frame by blueyed · Pull Request #17159 · python/cpython

Conversation

@blueyed

@blueyed blueyed commented Nov 15, 2019 •
edited by serhiy-storchaka
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The following will not stop for debugging:

python3.8 -c 'import pdb; pdb.Pdb(skip=["*"]).set_trace()'

The example is contrived, the real case would be to have some "noisy"
module being excluded in general, but when you add an explicit
"set_trace()" in there it should still stop there, and not on some upper
frame.

This was changed a long time already in
313a751
(Python 2.3), but it is not really clear.
/cc @ctismer

This PR is meant to see how reverting that part goes.

https://bugs.python.org/issue38806

  • Issue: "pdb.Pdb(skip=…).set_trace()" should always stop on calling frame #82987

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 15, 2019
@bedevere-bot bedevere-bot added the awaiting review label Nov 15, 2019
@blueyed blueyed changed the title bpo-38806: bdb: stop_here: always stop at calling frame [WIP] bpo-38806: bdb: stop_here: always stop at calling frame Nov 15, 2019
@blueyed blueyed mentioned this pull request Nov 15, 2019
stop_here: stop with None-stopframe pdbpp/pdbpp#336
Merged
1 task done
@blueyed

blueyed commented Nov 15, 2019

Copy link
Copy Markdown
Contributor Author

Note: with pdbpp I am remembering the frame in Pdb.set_trace already, which could be an option here also?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
blueyed added a commit to blueyed/pdbpp that referenced this pull request Nov 19, 2019
@blueyed
stop_here: always stop where set_trace was used from
585c569 
This is relevant for when `skip` is used.

Ref: https://bugs.python.org/issue38806
Ref: python/cpython#17159

NOTE: pypy2: needs the extra check for frame, which makes sense in general
      (via test_sigint_in_interaction_without_new_cmdloop).
blueyed added a commit to pdbpp/pdbpp that referenced this pull request Nov 19, 2019
@blueyed
stop_here: always stop where set_trace was used from (#336)
8e19a95 
This is relevant for when `skip` is used.

Ref: https://bugs.python.org/issue38806
Ref: python/cpython#17159

NOTE: pypy2: needs the extra check for frame, which makes sense in general
      (via test_sigint_in_interaction_without_new_cmdloop).
blueyed added 2 commits September 18, 2021 10:26
@blueyed
bpo-38806: bdb: stop_here: always stop at calling frame
561d3c1 
The following will not stop for debugging:

    python3.8 -c 'import pdb; pdb.Pdb(skip=["*"]).set_trace()'

The example is contrived, the real case would be to have some "noisy"
module being excluded in general, but when you add an explicit
"set_trace()" in there it should still stop there, and not on some upper
frame.

This was changed a long time already in
python@313a751
(Python 2.3), but it is not really clear.

This PR is meant to see how reverting that part goes.
@blueyed
test
cc60f41
@blueyed
blueyed force-pushed the is_skipped_module-stop-at-set_trace branch from 1c2e81e to cc60f41 Compare September 18, 2021 08:26
@ezio-melotti ezio-melotti removed the CLA signed label Jul 13, 2022
@serhiy-storchaka
serhiy-storchaka marked this pull request as draft January 17, 2024 20:08
@bedevere-app bedevere-app Bot removed the awaiting review label Jan 17, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Feb 24, 2025
"pdb.Pdb(skip=…).set_trace()" should always stop on calling frame #82987
Closed
@python-cla-bot

python-cla-bot Bot commented Apr 6, 2025

Copy link
Copy Markdown

The following commit authors need to sign the Contributor License Agreement:

  • [email protected]

CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Apr 7, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 7, 2026
@serhiy-storchaka serhiy-storchaka changed the title [WIP] bpo-38806: bdb: stop_here: always stop at calling frame [WIP] gh-82987: bdb: stop_here: always stop at calling frame Aug 12, 2026
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Aug 14, 2026
@ambv

ambv commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

This PR has not been touched by a human in more than 5 years. Closing to cull the number of open pull requests. Do not reopen this pull request without getting a go-ahead from a triager or core developer on the related issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv ambv closed this Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaogaotiantian gaogaotiantian Awaiting requested review from gaogaotiantian gaogaotiantian will be requested when the pull request is marked ready for review gaogaotiantian is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@blueyed @ambv @the-knights-who-say-ni @ezio-melotti @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.