GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — [3.7] bpo-38823: Clean up refleaks in _asyncio initialization. (GH-17195) by miss-islington · Pull Request #17197 · python/cpython

[3.7] bpo-38823: Clean up refleaks in _asyncio initialization. (GH-17195) #17197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

miss-islington merged 1 commit into python:3.7 from miss-islington:backport-c3f6bdc-3.7

Nov 16, 2019

Uh oh!

There was an error while loading. Please reload this page.

Merged

[3.7] bpo-38823: Clean up refleaks in _asyncio initialization. (GH-17195) #17197

Changes from all commits

Commits

Show all changes

1 commit

Select commit

695a0cc

bpo-38823: Clean up refleaks in _asyncio initialization. (GH-17195)

brandtbucher Nov 16, 2019

File filter

Filter by extension .c (1) All 1 file type selected

Viewed files

Clear filters

Conversations

Failed to load comments.

Uh oh!

There was an error while loading. Please reload this page.

Jump to

Jump to file

Failed to load files.

Uh oh!

There was an error while loading. Please reload this page.

Diff view

Unified

Split

Hide whitespace

Diff view

Unified

Split

Hide whitespace

bpo-38823: Clean up refleaks in _asyncio initialization. (GH-17195)

https://bugs.python.org/issue38823
(cherry picked from commit c3f6bdc)

Co-authored-by: Brandt Bucher <[email protected]>

Loading branch information

Uh oh!

There was an error while loading. Please reload this page.

brandtbucher authored and miss-islington committed Nov 16, 2019

commit 695a0cc31174ffd4de956b08ce8a4aef2ed903f9

There are no files selected for viewing

4 changes: 4 additions & 0 deletions 4 Modules/_asynciomodule.c

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -3361,24 +3361,28 @@ PyInit__asyncio(void)
		Py_INCREF(&FutureType);
		if (PyModule_AddObject(m, "Future", (PyObject *)&FutureType) < 0) {
		Py_DECREF(&FutureType);
		Py_DECREF(m);
		return NULL;
		}

		Py_INCREF(&TaskType);
		if (PyModule_AddObject(m, "Task", (PyObject *)&TaskType) < 0) {
		Py_DECREF(&TaskType);
		Py_DECREF(m);
		return NULL;
		}

		Py_INCREF(all_tasks);
		if (PyModule_AddObject(m, "_all_tasks", all_tasks) < 0) {
		Py_DECREF(all_tasks);
		Py_DECREF(m);
		return NULL;
		}

		Py_INCREF(current_tasks);
		if (PyModule_AddObject(m, "_current_tasks", current_tasks) < 0) {
		Py_DECREF(current_tasks);
		Py_DECREF(m);
		return NULL;
		}

Expand Down

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.