GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-38823: Clean up refleaks in _tkinter initialization. by brandtbucher · Pull Request #17206 · python/cpython

Conversation

@brandtbucher

@brandtbucher brandtbucher commented Nov 17, 2019 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue38823

Automerge-Triggered-By: @taleinat

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
zware reacted with thumbs up emoji armw4 reacted with hooray emoji
All reactions
  • 👍 1 reaction
  • 🎉 1 reaction
@brandtbucher
Clean up refleaks in module initialization.
e0d8b9c
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 17, 2019
@bedevere-bot bedevere-bot added the awaiting review label Nov 17, 2019
@brandtbucher brandtbucher added skip news type-bug An unexpected behavior, bug, or error labels Nov 17, 2019
taleinat
taleinat approved these changes Nov 18, 2019
View reviewed changes

@taleinat taleinat left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
brandtbucher and zware reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Nov 18, 2019
@taleinat taleinat added needs backport to 3.7 labels Nov 18, 2019
@miss-islington
miss-islington merged commit 289cf0f into python:master Nov 18, 2019
@miss-islington

miss-islington commented Nov 18, 2019

Copy link
Copy Markdown
Contributor

Thanks @brandtbucher for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed awaiting merge needs backport to 3.8 labels Nov 18, 2019
@bedevere-bot

bedevere-bot commented Nov 18, 2019

Copy link
Copy Markdown

GH-17226 is a backport of this pull request to the 3.8 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 18, 2019
@brandtbucher @miss-islington
bpo-38823: Clean up refleaks in _tkinter initialization. (pythonGH-17206
cc007ca 
)

https://bugs.python.org/issue38823
(cherry picked from commit 289cf0f)

Co-authored-by: Brandt Bucher <[email protected]>
@bedevere-bot

bedevere-bot commented Nov 18, 2019

Copy link
Copy Markdown

GH-17227 is a backport of this pull request to the 3.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Nov 18, 2019
miss-islington added a commit that referenced this pull request Nov 18, 2019
@miss-islington @brandtbucher
bpo-38823: Clean up refleaks in _tkinter initialization. (GH-17206)
9e4d031 
https://bugs.python.org/issue38823
(cherry picked from commit 289cf0f)

Co-authored-by: Brandt Bucher <[email protected]>
miss-islington added a commit that referenced this pull request Nov 18, 2019
@miss-islington @brandtbucher
bpo-38823: Clean up refleaks in _tkinter initialization. (GH-17206)
42a4359 
https://bugs.python.org/issue38823
(cherry picked from commit 289cf0f)

Co-authored-by: Brandt Bucher <[email protected]>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@brandtbucher Jake Taylor
bpo-38823: Clean up refleaks in _tkinter initialization. (pythonGH-17206
d7ba4a4 
)

https://bugs.python.org/issue38823
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@brandtbucher @shihai1991
bpo-38823: Clean up refleaks in _tkinter initialization. (pythonGH-17206
620716d 
)

https://bugs.python.org/issue38823
@brandtbucher
brandtbucher deleted the _tkinter branch July 21, 2022 20:00
@brandtbucher brandtbucher mentioned this pull request Apr 10, 2022
Improve stdlib module initialization error handling. #83004
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@taleinat taleinat taleinat approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@brandtbucher @miss-islington @bedevere-bot @taleinat @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.