GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-38823: Clean up refleaks in faulthandler initialization. by brandtbucher · Pull Request #17250 · python/cpython

Conversation

@brandtbucher

@brandtbucher brandtbucher commented Nov 19, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue38823

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@brandtbucher
Clean up refleaks in module initialization.
4e91aa6
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 19, 2019
@bedevere-bot bedevere-bot added the awaiting review label Nov 19, 2019
@brandtbucher brandtbucher added OS-windows skip news type-bug An unexpected behavior, bug, or error labels Nov 19, 2019
@brandtbucher

brandtbucher commented Nov 19, 2019

Copy link
Copy Markdown
Member Author

@vstinner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed Nov 19, 2019
View reviewed changes
Comment thread Modules/faulthandler.c Outdated
EXCEPTION_ACCESS_VIOLATION))
EXCEPTION_ACCESS_VIOLATION)) {
Py_DECREF(m);
return NULL;

@vstinner vstinner Nov 19, 2019

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, what do you think of adding a "error:" label which does the DECREF + return NULL?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@brandtbucher brandtbucher Nov 19, 2019

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually prefer that. I just wanted to keep the diffs small for all of these.

Should I make the change?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@brandtbucher brandtbucher Nov 19, 2019

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@brandtbucher
Use a labeled failure branch.
a0af66d
vstinner
vstinner reviewed Nov 19, 2019
View reviewed changes
Comment thread Modules/faulthandler.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@brandtbucher
Guard unused label.
46f8a0c
@vstinner
vstinner merged commit ac22354 into python:master Nov 19, 2019
@bedevere-bot bedevere-bot removed the awaiting review label Nov 19, 2019
@vstinner

vstinner commented Nov 19, 2019

Copy link
Copy Markdown
Member

Thanks. I took the liberty of rewriting the commit message.
brandtbucher reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner added needs backport to 3.7 labels Nov 19, 2019
@miss-islington

miss-islington commented Nov 19, 2019

Copy link
Copy Markdown
Contributor

Thanks @brandtbucher for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Nov 19, 2019

Copy link
Copy Markdown
Contributor

Thanks @brandtbucher for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 19, 2019
@brandtbucher @miss-islington
bpo-38823: Fix refleaks in faulthandler init error path on Windows (p…
21c7bb4 
…ythonGH-17250)

(cherry picked from commit ac22354)

Co-authored-by: Brandt Bucher <[email protected]>
@bedevere-bot

bedevere-bot commented Nov 19, 2019

Copy link
Copy Markdown

GH-17263 is a backport of this pull request to the 3.8 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Nov 19, 2019
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 19, 2019
@brandtbucher @miss-islington
bpo-38823: Fix refleaks in faulthandler init error path on Windows (p…
c67599f 
…ythonGH-17250)

(cherry picked from commit ac22354)

Co-authored-by: Brandt Bucher <[email protected]>
@bedevere-bot

bedevere-bot commented Nov 19, 2019

Copy link
Copy Markdown

GH-17264 is a backport of this pull request to the 3.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Nov 19, 2019
miss-islington added a commit that referenced this pull request Nov 19, 2019
@miss-islington @brandtbucher
bpo-38823: Fix refleaks in faulthandler init error path on Windows (G…
5bd2af9 
…H-17250)

(cherry picked from commit ac22354)

Co-authored-by: Brandt Bucher <[email protected]>
miss-islington added a commit that referenced this pull request Nov 19, 2019
@miss-islington @brandtbucher
bpo-38823: Fix refleaks in faulthandler init error path on Windows (G…
a5ed2fe 
…H-17250)

(cherry picked from commit ac22354)

Co-authored-by: Brandt Bucher <[email protected]>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@brandtbucher Jake Taylor
bpo-38823: Fix refleaks in faulthandler init error path on Windows (p…
fa263f4 
…ythonGH-17250)
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@brandtbucher @shihai1991
bpo-38823: Fix refleaks in faulthandler init error path on Windows (p…
4083578 
…ythonGH-17250)
@brandtbucher
brandtbucher deleted the faulthandler branch July 21, 2022 20:00
@brandtbucher brandtbucher mentioned this pull request Apr 10, 2022
Improve stdlib module initialization error handling. #83004
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

OS-windows skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@brandtbucher @vstinner @miss-islington @bedevere-bot @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.