GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-22257: Small changes for PEP 432. by ericsnowcurrently · Pull Request #1728 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented May 22, 2017

Copy link
Copy Markdown
Member

PEP 432 specifies a number of large changes to interpreter startup code, including exposing a cleaner C-API. The major changes depend on a number of smaller changes. This patch includes all those smaller changes. (The commits here each stand on their own so I'd rather the PR not be squashed.)

Note that regardless of the status of the PEP, the changes proposed by the PEP are an improvement to interpreter startup. As such we are making the changes, but keeping the C-API provisional.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 22, 2017
@ericsnowcurrently ericsnowcurrently changed the title Small changes for PEP 432. bpo-22257: Small changes for PEP 432. May 22, 2017
@ericsnowcurrently ericsnowcurrently mentioned this pull request May 22, 2017
bpo-22257: Private C-API for main interpreter initialization (PEP 432). #1729
Merged
@ericsnowcurrently

ericsnowcurrently commented May 22, 2017

Copy link
Copy Markdown
Member Author

@zooba
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently
ericsnowcurrently force-pushed the pep432-cleanup branch from 1f80ff5 to 4abd893 Compare May 22, 2017 22:34
@zooba

zooba commented May 22, 2017

Copy link
Copy Markdown
Member

Run PCBuild/fix_encoding.py to remove the BOM changes in that directory, but otherwise LGTM.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently
ericsnowcurrently force-pushed the pep432-cleanup branch from 4abd893 to 443d80f Compare May 22, 2017 22:59
@ericsnowcurrently

ericsnowcurrently commented May 22, 2017

Copy link
Copy Markdown
Member Author

FYI: the travis failures are due to using the -W flag.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently
ericsnowcurrently force-pushed the pep432-cleanup branch from 443d80f to 03b53a3 Compare May 22, 2017 23:43
ncoghlan added 7 commits May 22, 2017 18:13
@ncoghlan @ericsnowcurrently
Factor out _install_external_importers().
7b71497
@ncoghlan @ericsnowcurrently
Move compiler flags to compile.h.
72ca7c5
@ncoghlan @ericsnowcurrently
Add CLI tests.
1c41852
@ncoghlan @ericsnowcurrently
Add PyInterpreterState_Main().
406d3d2
@ncoghlan @ericsnowcurrently
Rename random.c to bootstrap_hash.c.
ee647de
@ncoghlan @ericsnowcurrently
Split up _PySys_Init().
070e7d5
@ncoghlan @ericsnowcurrently
Factor out _Py_CommandLineDetails.
07089e4
@ericsnowcurrently
ericsnowcurrently force-pushed the pep432-cleanup branch from 03b53a3 to 07089e4 Compare May 23, 2017 01:28
@ericsnowcurrently
ericsnowcurrently merged commit 6b4be19 into python:master May 23, 2017
@ericsnowcurrently
ericsnowcurrently deleted the pep432-cleanup branch May 23, 2017 04:36
@ericsnowcurrently ericsnowcurrently mentioned this pull request May 23, 2017
bpo-22257: Fix CLI by using int instead of char (compares to EOF). #1765
Merged
@AdamWill AdamWill mentioned this pull request Feb 26, 2019
Python scripting plugin crashes on unload with Python 3.7 hexchat/hexchat#2237
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ericsnowcurrently @zooba @the-knights-who-say-ni @ncoghlan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.