GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-22257: Fix CLI by using int instead of char (compares to EOF). by ericsnowcurrently · Pull Request #1765 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented May 23, 2017

Copy link
Copy Markdown
Member

This slipped through in PR #1728.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ericsnowcurrently
bpo-22257: Fix CLI by using int instead of char (compares to EOF).
b707902
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 23, 2017
@mention-bot

mention-bot commented May 23, 2017

Copy link
Copy Markdown

@ericsnowcurrently, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ncoghlan, @tiran and @Yhg1s to be potential reviewers.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently

ericsnowcurrently commented May 23, 2017

Copy link
Copy Markdown
Member Author

@zooba
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently

ericsnowcurrently commented May 23, 2017

Copy link
Copy Markdown
Member Author

@ncoghlan
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently
ericsnowcurrently merged commit e0918ec into python:master May 23, 2017
@ericsnowcurrently
ericsnowcurrently deleted the fix-broken-cli branch May 23, 2017 19:26
@ericsnowcurrently ericsnowcurrently mentioned this pull request May 23, 2017
bpo-22257: Revert an invalid change to a test (from 6b4be19). #1770
Merged
serhiy-storchaka added a commit that referenced this pull request May 23, 2017
@serhiy-storchaka
Revert "bpo-22257: Fix CLI by using int instead of char (compares to …
eca3ab7 
…EOF). (#1765)"

This reverts commit e0918ec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ericsnowcurrently @mention-bot @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.