GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-26730: Fix SpooledTemporaryFile data corruption by methane · Pull Request #17400 · python/cpython

Conversation

methane commented Nov 27, 2019 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

https://bugs.python.org/issue26730

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

methane added 3 commits

November 27, 2019 16:09


          bpo-26730: Fix SpooledTemporaryFile data corruption

547b06f

SpooledTemporaryFile.rollback() might cause data corruption
when it is in text mode.


          update doc

ecb8858


          Add NEWS

30bb694

the-knights-who-say-ni added the CLA signed label

Nov 27, 2019

bedevere-bot added the awaiting core review label

Nov 27, 2019

methane added needs backport to 3.7 type-bug An unexpected behavior, bug, or error labels

Nov 27, 2019

serhiy-storchaka approved these changes

Nov 27, 2019

View reviewed changes

serhiy-storchaka left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about the function to class change. Let to left this to other issue. It needs a separate discussion. It might be discussed earlier.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot added awaiting merge and removed awaiting core review labels

Nov 27, 2019

methane added 4 commits

November 27, 2019 19:38


          revert function -> class

adce72b


          Pass errors to TextIOWrapper

70aeefa


          write_through is not required

4b3d857


          update test

c5fac2a

methane merged commit ea9835c into python:master

Nov 27, 2019

methane deleted the text-spooledtempfile branch

November 27, 2019 13:22

miss-islington commented Nov 27, 2019

Copy link

Copy Markdown

Contributor

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting merge label

Nov 27, 2019

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Nov 27, 2019


          bpo-26730: Fix SpooledTemporaryFile data corruption (pythonGH-17400)

3ff8cc1

SpooledTemporaryFile.rollback() might cause data corruption
when it is in text mode.

Co-Authored-By: Serhiy Storchaka <[email protected]>
(cherry picked from commit ea9835c)

Co-authored-by: Inada Naoki <[email protected]>

bedevere-bot commented Nov 27, 2019

Copy link

Copy Markdown

GH-17405 is a backport of this pull request to the 3.8 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.8 label

Nov 27, 2019

miss-islington commented Nov 27, 2019

Copy link

Copy Markdown

Contributor

Sorry, @methane, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ea9835c5d154ab6a54eed627958473b6768b28cc 3.7

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington assigned methane

Nov 27, 2019

methane added a commit that referenced this pull request

Nov 27, 2019


          [3.7] bpo-26730: Fix SpooledTemporaryFile data corruption (GH-17400)

ea0fecb

SpooledTemporaryFile.rollback() might cause data corruption
when it is in text mode.

Co-Authored-By: Serhiy Storchaka <[email protected]>.
(cherry picked from commit ea9835c)

Co-authored-by: Inada Naoki <[email protected]>

bedevere-bot removed the needs backport to 3.7 label

Nov 27, 2019

bedevere-bot commented Nov 27, 2019

Copy link

Copy Markdown

GH-17407 is a backport of this pull request to the 3.7 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington added a commit that referenced this pull request

Nov 28, 2019


          bpo-26730: Fix SpooledTemporaryFile data corruption (GH-17400)

d21b8e8

SpooledTemporaryFile.rollback() might cause data corruption
when it is in text mode.

Co-Authored-By: Serhiy Storchaka <[email protected]>
(cherry picked from commit ea9835c)

Co-authored-by: Inada Naoki <[email protected]>

methane added a commit that referenced this pull request

Nov 28, 2019


          bpo-26730: Fix SpooledTemporaryFile data corruption (GH-17400)

e65b3fa

SpooledTemporaryFile.rollback() might cause data corruption
when it is in text mode.

Co-Authored-By: Serhiy Storchaka <[email protected]>.
(cherry picked from commit ea9835c)

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request

Dec 5, 2019


          bpo-26730: Fix SpooledTemporaryFile data corruption (pythonGH-17400)

8c95dd9

SpooledTemporaryFile.rollback() might cause data corruption
when it is in text mode.

Co-Authored-By: Serhiy Storchaka <[email protected]>

shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request

Jan 31, 2020


          bpo-26730: Fix SpooledTemporaryFile data corruption (pythonGH-17400)

SpooledTemporaryFile.rollback() might cause data corruption
when it is in text mode.

Co-Authored-By: Serhiy Storchaka <[email protected]>

jtrh mentioned this pull request

Jul 9, 2020

tempfile.SpooledTemporaryFile.encoding is None when the encoding parameter is utf-8 cordada/lib-cl-sii-python#120

Closed

jstasiak mentioned this pull request

May 30, 2024

ipaddress: Shared Address Space (100.64.0.0/10) is neither private nor global #119812

Open

Reviewers

serhiy-storchaka

serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

methane

Labels

type-bug

An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

methane commented Nov 27, 2019 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington commented Nov 27, 2019

Uh oh!

bedevere-bot commented Nov 27, 2019

Uh oh!

miss-islington commented Nov 27, 2019

Uh oh!

bedevere-bot commented Nov 27, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

methane commented Nov 27, 2019 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.