GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-35134: Migrate frameobject.h contents to cpython/frameobject.h by ncoghlan · Pull Request #18052 · python/cpython

Conversation

@ncoghlan

@ncoghlan ncoghlan commented Jan 18, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The patch for PEP 558 (bpo-30744) adds a number of new frame-related
C APIs. This prepatory patch migrates frameobject.h to the modern layout
with multiple include files so the PEP reference implementation can clearly
separate the stable ABI additions from the full CPython C API additions.

https://bugs.python.org/issue35134

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ncoghlan
Migrate frameobject.h contents to cpython/frameobject.h
187f970
@ncoghlan
ncoghlan requested a review from vstinner January 18, 2020 13:51
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 18, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Jan 18, 2020
@ncoghlan ncoghlan added skip news skip issue labels Jan 18, 2020
@ncoghlan ncoghlan mentioned this pull request Jan 18, 2020
[PEP 558 - WIP] bpo-30744: Trace hooks no longer reset closure state #3640
Closed
17 of 27 tasks
vstinner
vstinner approved these changes Jan 19, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You can use bpo-35134 in the commit title if you want.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jan 19, 2020
@ncoghlan ncoghlan changed the title Migrate frameobject.h contents to cpython/frameobject.h bpo-35134: Migrate frameobject.h contents to cpython/frameobject.h Jan 20, 2020
@ncoghlan ncoghlan removed the skip issue label Jan 20, 2020
@ncoghlan
ncoghlan merged commit 1e420f8 into python:master Jan 20, 2020
@ncoghlan
ncoghlan deleted the move-frameobject-header branch January 20, 2020 22:21
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 20, 2020
@ncoghlan

ncoghlan commented Jan 20, 2020

Copy link
Copy Markdown
Contributor Author

Thanks for the review!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@ncoghlan @shihai1991
bpo-35134: Migrate frameobject.h contents to cpython/frameobject.h (p…
6f10493 
…ythonGH-18052)
@njsmith njsmith mentioned this pull request Apr 10, 2022
Local variable assignment is broken when combined with threads + tracing + closures #74929
Closed
@vstinner vstinner mentioned this pull request Apr 10, 2022
Add a new Include/cpython/ subdirectory for the "CPython API" with implementation details #79315
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ncoghlan @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.