GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-39320: Handle unpacking of **values in compiler by markshannon · Pull Request #18141 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Jan 23, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is the second part of the implementation of bpo-39320.
Part 1 was #17984

This PR replaces BUILD_MAP_UNPACK and BUILD_MAP_UNPACK_WITH_CALL
with DICT_MERGE and DICT_UPDATE.

DICT_UPDATE n calls item_n.update(tos) where item_n is the nth item on the stack and tos is popped from the stack.
DICT_MERGE n is the same, but raises an exception if there are duplicate keys.

https://bugs.python.org/issue39320

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
markshannon added 4 commits January 23, 2020 09:30
@markshannon
Add DICT_UPDATE and DICT_MERGE bytecodes. Use them for ** unpacking.
33464eb
@markshannon
Remove BUILD_MAP_UNPACK and BUILD_MAP_UNPACK_WITH_CALL, as they are n…
d123328 
…ow unused.
@markshannon
Update magic number for ** unpacking opcodes.
6b9f0c4
@markshannon
Update dis.rst to incorporate new bytecodes.
7a05eca
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 23, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Jan 23, 2020
@markshannon
Add blurb entry.
95e421c
@markshannon
markshannon force-pushed the handle-dict-unpacking-in-compiler branch from b6ad237 to 95e421c Compare January 23, 2020 10:11
pablogsal
pablogsal reviewed Jan 23, 2020
View reviewed changes
Comment thread Misc/NEWS.d/next/Core and Builtins/2020-01-15-15-50-22.bpo-39320.oWARyk.rst Outdated
@@ -0,0 +1,12 @@

Replace two complex bytecodes for building dicts with two simpler ones.

@pablogsal pablogsal Jan 23, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Different paragraphs render badly when joining the NEWS entries, sadly

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@markshannon
Make news item a single paragraph.
2d2fe4c
@markshannon markshannon added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 23, 2020
@bedevere-bot

bedevere-bot commented Jan 23, 2020

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @markshannon for commit 2d2fe4c 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 23, 2020
@pablogsal

pablogsal commented Jan 23, 2020

Copy link
Copy Markdown
Member

The failures in AMD64 Fedora Stable Clang Installed PR , buildbot/PPC64 Fedora PR and buildbot/x86 Gentoo Installed with X PR are unrelated so don't worry about them.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markshannon

markshannon commented Jan 27, 2020

Copy link
Copy Markdown
Member Author

OK, merging.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markshannon
markshannon merged commit 8a4cd70 into python:master Jan 27, 2020
@markshannon
markshannon deleted the handle-dict-unpacking-in-compiler branch January 27, 2020 09:57
@bedevere-bot bedevere-bot removed the awaiting core review label Jan 27, 2020
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@markshannon @shihai1991
bpo-39320: Handle unpacking of **values in compiler (pythonGH-18141)
5d539e8 
* Add DICT_UPDATE and DICT_MERGE bytecodes. Use them for ** unpacking.

* Remove BUILD_MAP_UNPACK and BUILD_MAP_UNPACK_WITH_CALL, as they are now unused.

* Update magic number for ** unpacking opcodes.

* Update dis.rst to incorporate new bytecodes.

* Add blurb entry.
@sobolevn sobolevn mentioned this pull request Sep 11, 2022
Dead code in CALL_FUNCTION_EX opcode handler #96751
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@markshannon @bedevere-bot @pablogsal @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.