GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-39573: Fix bad copy-paste in Py_SET_SIZE. by brandtbucher · Pull Request #18496 · python/cpython

Conversation

@brandtbucher

@brandtbucher brandtbucher commented Feb 13, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@vstinner

https://bugs.python.org/issue39573

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@brandtbucher
refcnt -> size
90df6ea
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 13, 2020
@brandtbucher
brandtbucher requested a review from vstinner February 13, 2020 01:43
@bedevere-bot bedevere-bot added the awaiting review label Feb 13, 2020
@brandtbucher brandtbucher added the skip news label Feb 13, 2020
@vstinner vstinner mentioned this pull request Feb 13, 2020
bpo-39573: Add Py_IS_TYPE macro #18488
Merged
vstinner
vstinner reviewed Feb 13, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also noticed a typo in Py_SET_SIZE() doc:
https://docs.python.org/dev/c-api/structures.html#c.Py_SET_SIZE

"Set the object o size of size." => "Set ... to size."

Would you mind to also fix it, please?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
brandtbucher reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@brandtbucher
to -> of
6d4ee95
@codecov

codecov Bot commented Feb 13, 2020

Copy link
Copy Markdown

Codecov Report

Merging #18496 into master will increase coverage by 1.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #18496       +/-   ##
===========================================
+ Coverage   82.10%   83.20%    +1.09%     
===========================================
  Files        1958     1571      -387     
  Lines      589576   414668   -174908     
  Branches    44449    44450        +1     
===========================================
- Hits       484095   345007   -139088     
+ Misses      95833    60017    -35816     
+ Partials     9648     9644        -4
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-7.15%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.77%) ⬇️
Lib/test/test_asyncio/test_base_events.py 91.84% <0.00%> (-3.30%) ⬇️
... and 442 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c3aee6...6d4ee95. Read the comment docs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 968dcd9 into python:master Feb 13, 2020
@bedevere-bot bedevere-bot removed the awaiting review label Feb 13, 2020
@vstinner

vstinner commented Feb 13, 2020

Copy link
Copy Markdown
Member

Thanks. I'm feeling ashamed by these typos, but I'm also feeling better after your fix :-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brandtbucher

brandtbucher commented Feb 13, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Thanks! Besides, maybe there's some use-case out there for Py_SIZE(o) == Py_REFCNT(o)! 😉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brandtbucher
brandtbucher deleted the refcnt-size branch February 13, 2020 17:42
faraz-mtk pushed a commit to MediaTek-Labs/cpython that referenced this pull request Nov 12, 2021
Roumen Petrov Faraz Shahbazker
Issue python#18496: MINGW: setup exclude termios module
0deee19
@vstinner vstinner mentioned this pull request Mar 12, 2024
[C API] Avoid accessing PyObject and PyVarObject members directly: add Py_SET_TYPE() and Py_IS_TYPE(), disallow Py_TYPE(obj)=type #83754
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@brandtbucher @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.