GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-64383: Migrate builtins.vars and builtins.dir to Argument Clinic by shihai1991 · Pull Request #18512 · python/cpython

Conversation

@shihai1991

@shihai1991 shihai1991 commented Feb 15, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue20184

  • Issue: Derby #16: Convert 50 sites to Argument Clinic across 9 files #64383

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@shihai1991
Migrate builtins.vars and builtins.dir to Argument Clinic
a0ce88e
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 15, 2020
@bedevere-bot bedevere-bot added the awaiting review label Feb 15, 2020
@shihai1991
shihai1991 requested a review from ncoghlan February 15, 2020 10:23
@blurb-it
📜🤖 Added by blurb_it.
3b315ef
@codecov

codecov Bot commented Feb 15, 2020

Copy link
Copy Markdown

Codecov Report

Merging #18512 into master will increase coverage by 3.73%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #18512       +/-   ##
===========================================
+ Coverage   79.46%   83.20%    +3.73%     
===========================================
  Files         384     1571     +1187     
  Lines      169290   414730   +245440     
  Branches        0    44456    +44456     
===========================================
+ Hits       134529   345067   +210538     
- Misses      34761    60020    +25259     
- Partials        0     9643     +9643
Impacted Files Coverage Δ
Python/dynload_shlib.c
Parser/parsetok.c
Python/marshal.c
Python/hamt.c
Python/clinic/sysmodule.c.h
Objects/bytes_methods.c
Modules/_hashopenssl.c
Modules/_ctypes/callbacks.c
Modules/cjkcodecs/cjkcodecs.h
Objects/capsule.c
... and 1943 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f632736...3b315ef. Read the comment docs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@shihai1991
shihai1991 requested a review from larryhastings February 15, 2020 11:00
@JelleZijlstra

JelleZijlstra commented Apr 17, 2022

Copy link
Copy Markdown
Member

Sorry this had to wait for so long! If you're still interested, would you be able to fix the merge conflicts? Then I can review it and get it merged.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@shihai1991

shihai1991 commented Apr 19, 2022

Copy link
Copy Markdown
Member Author

Sorry this had to wait for so long! If you're still interested, would you be able to fix the merge conflicts? Then I can review it and get it merged.

Oh, Thanks. Give me some time to take a look. I forget the details already :(
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka serhiy-storchaka added the topic-argument-clinic label Apr 30, 2022
@ezio-melotti ezio-melotti removed the CLA signed label Jul 13, 2022
hauntsaninja
hauntsaninja requested changes Feb 9, 2023
View reviewed changes

@hauntsaninja hauntsaninja left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for fixing the conflicts, as per above

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting review labels Feb 9, 2023
@bedevere-bot

bedevere-bot commented Feb 9, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arhadthedev arhadthedev changed the title bpo-20184: Migrate builtins.vars and builtins.dir to Argument Clinic gh-64383: Migrate builtins.vars and builtins.dir to Argument Clinic Feb 13, 2023
@arhadthedev arhadthedev added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Feb 13, 2023
@arhadthedev

arhadthedev commented Feb 13, 2023

Copy link
Copy Markdown
Member

Superseded by gh-100358.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arhadthedev arhadthedev closed this Feb 13, 2023
@larryhastings larryhastings mentioned this pull request Feb 13, 2023
Derby #16: Convert 50 sites to Argument Clinic across 9 files #64383
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja requested changes
@ncoghlan ncoghlan Awaiting requested review from ncoghlan
@larryhastings larryhastings Awaiting requested review from larryhastings

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting changes interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-argument-clinic

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@shihai1991 @JelleZijlstra @bedevere-bot @arhadthedev @hauntsaninja @serhiy-storchaka @the-knights-who-say-ni @ezio-melotti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.