GeezerVison is showing github.com — Derby #16: Convert 50 sites to Argument Clinic across 9 files · Issue #64383 · python/cpython
Derby #16: Convert 50 sites to Argument Clinic across 9 files #64383Description
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = None
created_at = <Date 2014-01-08.00:21:44.691>
labels = ['extension-modules', 'type-feature', 'expert-argument-clinic']
title = 'Derby #16: Convert 50 sites to Argument Clinic across 9 files'
updated_at = <Date 2020-10-18.14:54:14.974>
user = 'https://github.com/larryhastings' bugs.python.org fields:
activity = <Date 2020-10-18.14:54:14.974>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Extension Modules', 'Argument Clinic']
creation = <Date 2014-01-08.00:21:44.691>
creator = 'larry'
dependencies = []
files = ['33696', '33701', '33740', '33860', '33861', '34664', '36385', '39032', '39070', '39292']
hgrepos = []
issue_num = 20184
keywords = ['patch']
message_count = 20.0
messages = ['207642', '209159', '209179', '209203', '209409', '209953', '210218', '210375', '215164', '224765', '225385', '225423', '225424', '225425', '241094', '241226', '241347', '242588', '362008', '378872']
nosy_count = 7.0
nosy_names = ['ncoghlan', 'larry', 'nadeem.vawda', 'python-dev', 'serhiy.storchaka', 'yselivanov', 'shihai1991']
pr_nums = ['18512', '22693']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue20184'
versions = ['Python 3.5'] Activitylarryhastings commented on Jan 8, 2014 ContributorAuthor More actions ncoghlan commented on Jan 25, 2014 I'm going to specifically tackle the "bltinmodule" side of things using a test driven approach: adding a new test to test_inspect that checks all the builtin names have signatures (I'll explicitly exclude ones that are known not to be handled, like range and slice). ncoghlan commented on Jan 25, 2014 Attached patch shows the new test case I'm using to ensure that all callable builtins have signatures, and once we get it that way, it stays that way.
Preliminary goal is signatures for all the non-type objects, and once I get to that point, I'll propose it for review. ncoghlan commented on Jan 25, 2014 More comprehensive patch uploaded - all the non-type callables implemented in bltinmodule.c have been converted or classified with a reason for not being converted yet (see the new test in test_inspect.py for details, as well as the AC 3.4 and AC 3.5 comments in the module itself).
I also cleaned up the docstrings for the builtins I actually changed in the patch. There were a few that had never been properly updated for the Py3k transition.
There are still a couple of test failures with this version - the doctest tests get confused by the fact ord and chr now have a doctest in their docstrings, and test_gdb is definitely not in a happy place (that has always been temperamental, though).
I also just realised the Unicode character in the new ord and chr docstrings could pose a compatibility problem at the C compiler source encoding level, so we may have to reconsider that (even though I was rather happy to sneak that obscure Monty Python reference in there). ncoghlan commented on Jan 27, 2014 Assigning to myself to make it clear that bltinmodule is the only part of this still under consideration for 3.4.
The test_pydoc and test_gdb failures pointed to real issues with the previous patch:
-
the pydoc errors themselves were incidental, indicating that I had added doctests to chr and ord. However, those new doctests used a Unicode character in a C string, which seems like a recipe for portability trouble. I took those doctests out again, and updated the prose docs instead. I like my obscure multilingual Monty Python reference and would like to keep it now I thought of it :)
-
the gdb error suggests that gdb is relying on being able to find builtin_id based on its exact signature, including the parameter names. Rather than trying to figure out the full details of that, I've instead partially reverted its conversion to Argument Clinic by disabling the input block and restoring the old parameter names in the function signature. We can change it back to full conversion for 3.5, after AC has the ability to use different names in the Python signature and in the C implementation function.
This does mean we'll want to update the signature by hand once you merge the patch changing the indicators that argument clinic is looking for. ncoghlan commented on Feb 2, 2014 Larry, if this version looks good to you, I'd like to commit it.
-
id() is now back to being a properly generated AC function (since AC can now preserve the old C level signature)
-
sorted() is partially converted and has a __text_signature__ compatible docstring. However, full conversion will have to wait for the ability to preserve the kwds dict, since that's the API exposed by the list object.
-
with the new never-triggered-by-accident AC syntax, the test case now ensures that all the builtins that are expected to *not* expose signature info at this point, don't. As they're converted for 3.5, that will force them to be added to the list of functions that are checked for compatibility.
I'm thinking it's probably worth flagging this new test as a CPython implementation detail test, though. ncoghlan commented on Feb 4, 2014 Larry, I'd like to include the most-builtin-functions signature support for 3.4, but since the AC Derby is over, it's your call as release manager.
If it looks good to you, go ahead and commit it (I won't have time until later in the week), otherwise just drop the priority and punt it to 3.5. ncoghlan commented on Feb 6, 2014 Interpreting the lack of response as "this can wait until 3.5". serhiy-storchaka commented on Apr 15, 2015 Proposed patch converts _dbm and _gdbm modules to Argument Clinic. serhiy-storchaka commented on Apr 16, 2015 The patch updated to the tip. python-dev commented on Apr 17, 2015 serhiy-storchaka commented on May 5, 2015 Here is a patch that converts 3 functions in the _json module to Argument Clinic. All other functions doesn't fit with Argument Clinic. shihai1991 commented on Feb 15, 2020 Looks like builtins.vars and builtins.dir should be migrated to AC too, so I create PR18512. serhiy-storchaka commented on Oct 18, 2020 arhadthedev commented on Feb 13, 2023 Is this metaissue still relevant after nine years? Currently, conversions into AC are handled in smaller, more specific issues so it could be closed. arhadthedev commented on Feb 14, 2023 BTW, the derby has a few more parts:
carljm commented on Feb 20, 2023 It looks to me like all of these derby issues would be better closed. Even if some functions do remain unconverted, it's much more likely at this point that they will be converted because someone notices the unconverted function in the codebase, not because of a derby issue with non-descriptive (and almost certainly now obsolete) name that requires digging through all of the listed modules to see if there's any work remaining to be done on it.
As the derby issues say, it was an effort to convert as much as possible before Python 3.4 release. Python 3.4 is long ago released, so the derby is over. Reacted by Erlend E. Aasland and Irit Katriel carljm commented on Feb 20, 2023 Will leave this open for a bit to see if a core dev agrees before closing all of them. iritkatriel commented on Feb 20, 2023
Will leave this open for a bit to see if a core dev agrees before closing all of them.
It's been open for long enough now. Reacted by Carl Meyer and Hai Shi
MetadataMetadataDevelopmentNo branches or pull requestsIssue actions
|