GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-39573: Use Py_IS_TYPE for negative type checks by petdance · Pull Request #18798 · python/cpython

Conversation

@petdance

@petdance petdance commented Mar 6, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Final batch of conversion to use Py_IS_TYPE.

https://bugs.python.org/issue39573

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@petdance
Use Py_IS_TYPE for negative type checks
4530050
@petdance
petdance requested a review from rhettinger as a code owner March 6, 2020 05:51
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 6, 2020
@bedevere-bot bedevere-bot added the awaiting review label Mar 6, 2020
@petdance petdance mentioned this pull request Mar 6, 2020
bpo-39573: Use Py_IS_TYPE for type checking #18789
Closed
@petdance

petdance commented Mar 6, 2020

Copy link
Copy Markdown
Contributor Author

Attn: @vstinner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Mar 6, 2020

Copy link
Copy Markdown
Member

I merged PR #18799. Would you mind to rebase this PR on top of master, please?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Mar 6, 2020
bpo-39873: PyObject_Init() uses PyObject_INIT() #18804
Merged
@petdance petdance mentioned this pull request Mar 6, 2020
bpo-39573: Use Py_IS_TYPE to check for types #18809
Merged
@petdance

petdance commented Mar 6, 2020

Copy link
Copy Markdown
Contributor Author

I replaced it with a new PR #18809
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@petdance petdance closed this Mar 6, 2020
@petdance
petdance deleted the bpo-39573-C branch March 7, 2020 04:05
@vstinner vstinner mentioned this pull request Mar 12, 2024
[C API] Avoid accessing PyObject and PyVarObject members directly: add Py_SET_TYPE() and Py_IS_TYPE(), disallow Py_TYPE(obj)=type #83754
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@petdance @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.