GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-39573: Make Py_IS_TYPE take const args. Add _PyObject_CAST_CONST. by petdance · Pull Request #18799 · python/cpython

Conversation

@petdance

@petdance petdance commented Mar 6, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

As the final part of the Py_IS_TYPE conversion:

  • Make Py_IS_TYPE take const arguments
  • Make new macro _PyObject_CAST_CONST

https://bugs.python.org/issue39573

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@petdance
Make Py_IS_TYPE take const args. Add _PyObject_CAST_CONST.
4f2017b
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 6, 2020
@bedevere-bot bedevere-bot added the awaiting review label Mar 6, 2020
@petdance petdance mentioned this pull request Mar 6, 2020
bpo-39573: Use Py_IS_TYPE for type checking #18789
Closed
@petdance

petdance commented Mar 6, 2020

Copy link
Copy Markdown
Contributor Author

Attn: @vstinner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner added the skip news label Mar 6, 2020
vstinner
vstinner approved these changes Mar 6, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I checked for compiler warnings on Windows, macOS and Linux (clang and GCC). I didn't notice any new warning.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Mar 6, 2020
@vstinner
vstinner merged commit 8767ce9 into python:master Mar 6, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 6, 2020
This was referenced Mar 6, 2020
bpo-39573: Use Py_IS_TYPE for negative type checks #18798
Closed
bpo-39873: PyObject_Init() uses PyObject_INIT() #18804
Merged
@petdance
petdance deleted the bpo-39573-D branch March 6, 2020 16:43
@vstinner vstinner mentioned this pull request Mar 12, 2024
[C API] Avoid accessing PyObject and PyVarObject members directly: add Py_SET_TYPE() and Py_IS_TYPE(), disallow Py_TYPE(obj)=type #83754
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@petdance @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.