GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — Rename Doc/README.txt to Doc/README.rst · Pull Request #19 · python/cpython Conversation
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
methane
approved these changes
methane
requested changes
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This PR renames Doc/README.txt to Doc/README.rst.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, I'm sorry. I misundersttod.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
methane
approved these changes
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, I'm sorry. I misundersttod.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
vstinner
requested changes
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I suggest to take the opportunity of this change to not only rename README.txt to README.rst but also make some reST syntax enhancements like using reST syntax for links.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
There was an error while loading. Please reload this page.
|
@methane MY CLA still has not been marked, and I currently have this: It's been two days since I submitted it, any update? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Why was this change tagged as "backport to 3.6"? Was it made in the 3.6 branch? If yes, please redo it in the master branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
No, it was made in the master branch @Haypo |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@Haypo Can you give me an example as to how you would like the link formatted? I'm more used to writing in markdown than I am in reST |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Look at README.rst in the root directory. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I suggested different text where [...] is the link.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
|
||
| Bugs in the toolset should be reported in the Sphinx bug tracker at | ||
| https://www.bitbucket.org/birkenfeld/sphinx/issues/. | ||
| `bitbucket.org/birkenfeld/sphinx/issues/ <https://www.bitbucket.org/birkenfeld/sphinx/issues/>`_. |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I suggest "Bugs in the toolset should be reported in the [Sphinx bug tracker]."
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| @@ -109,10 +109,10 @@ Contributing | |||
| ============ | |||
|
|
|||
| Bugs in the content should be reported to the Python bug tracker at | |||
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
"Bugs in the content should be reported to the [Python bug tracker]."
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| You need to have `Sphinx <http://sphinx-doc.org/>`_ installed; it is the toolset | ||
| used to build the docs. It is not included in this tree, but maintained | ||
| separately and available from PyPI <https://pypi.python.org/pypi/Sphinx>. | ||
| separately and available from `PyPI <https://pypi.python.org/pypi/Sphinx>`_. |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
and [available from PyPI].
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| This directory contains the reStructuredText (reST) sources to the Python | ||
| documentation. You don't need to build them yourself, prebuilt versions are | ||
| available at <https://docs.python.org/dev/download.html>. | ||
| available at `docs.python.org/dev/download.html <https://docs.python.org/dev/download.html>`_. |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
..., [prebuilt versions are available].
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
The reason the CLA bot is not showing me as signed is probably because I used the online editor for the original commit (which commits under the noreply@github address). My email address is |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Codecov Report
@@ Coverage Diff @@ ## master #19 +/- ## ========================================== - Coverage 82.37% 82.37% -0.01% ========================================== Files 1427 1427 Lines 350948 350948 ========================================== - Hits 289091 289089 -2 - Misses 61857 61859 +2 Continue to review full report at Codecov.
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@Haypo The changes you requested were made |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
19: Warn for range and xrange r=ltratt a=nanjekyejoannah See notes: ``` Py2.x: >>> x = xrange(1, 10000) >>> a = range(1,10000) >>> type(a) <type 'list'> >>> Py3.x: >>> x = xrange(1, 10000) Traceback (most recent call last): File "<stdin>", line 1, in <module> NameError: name 'xrange' is not defined >>> a = range(1,10000) >>> type(a) <class 'range'> >>> ``` Co-authored-by: Joannah Nanjekye <[email protected]>
* fix: off by one error in forward jump calculation * Test: fixed test for python#18 * test: remove broken test --------- Co-authored-by: Jules <[email protected]>
There are still some issues with compilation, but those can be sorted out in a future PR.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.