GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-1635741: Fix possible refleaks in tupleobject.c by shihai1991 · Pull Request #19018 · python/cpython

Conversation

@shihai1991

@shihai1991 shihai1991 commented Mar 15, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue1635741

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@shihai1991
fix possible refleaks in tupleobject.c
ae51e4f
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 15, 2020
@bedevere-bot bedevere-bot added the awaiting review label Mar 15, 2020
@pablogsal pablogsal added needs backport to 3.7 skip news labels Mar 15, 2020
pablogsal
pablogsal approved these changes Mar 15, 2020
View reviewed changes

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good catch :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Mar 15, 2020
@pablogsal
pablogsal merged commit c81609e into python:master Mar 15, 2020
@miss-islington

miss-islington commented Mar 15, 2020

Copy link
Copy Markdown
Contributor

Thanks @shihai1991 for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 15, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 15, 2020
@shihai1991 @miss-islington
Fix a possible refleak in tupleobject.c (pythonGH-19018)
d6b8272 
(cherry picked from commit c81609e)

Co-authored-by: Hai Shi <[email protected]>
@bedevere-bot

bedevere-bot commented Mar 15, 2020

Copy link
Copy Markdown

GH-19021 is a backport of this pull request to the 3.8 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Mar 15, 2020
@bedevere-bot

bedevere-bot commented Mar 15, 2020

Copy link
Copy Markdown

GH-19022 is a backport of this pull request to the 3.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Mar 15, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 15, 2020
@shihai1991 @miss-islington
Fix a possible refleak in tupleobject.c (pythonGH-19018)
2b3c968 
(cherry picked from commit c81609e)

Co-authored-by: Hai Shi <[email protected]>
miss-islington added a commit that referenced this pull request Mar 15, 2020
@miss-islington @shihai1991
Fix a possible refleak in tupleobject.c (GH-19018)
627e7bc 
(cherry picked from commit c81609e)

Co-authored-by: Hai Shi <[email protected]>
miss-islington added a commit that referenced this pull request Mar 15, 2020
@miss-islington @shihai1991
Fix a possible refleak in tupleobject.c (GH-19018)
890dcfe 
(cherry picked from commit c81609e)

Co-authored-by: Hai Shi <[email protected]>
@shihai1991

shihai1991 commented Mar 16, 2020

Copy link
Copy Markdown
Member Author

Thanks, Pablo.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Py_Finalize() doesn't clear all Python objects at exit #44470
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@shihai1991 @miss-islington @bedevere-bot @pablogsal @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.