GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-35037 Fix issue in cython project: Cython files don't compile on Mingw-w64 64-bit by BenjaminLiuPenrose · Pull Request #19326 · python/cpython

Conversation

@BenjaminLiuPenrose

@BenjaminLiuPenrose BenjaminLiuPenrose commented Apr 3, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Reference Issues/PRs

bpo-40167 https://bugs.python.org/issue40167
fixes cython project issue in cython/cython#3405

What does this implement/fix? Explain your changes.

fix Cython files don't compile on Mingw-w64 64-bit problem

https://bugs.python.org/issue40167

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@BenjaminLiuPenrose
Cython files don't compile on Mingw-w64 64-bit fix
f5125b4
@BenjaminLiuPenrose
BenjaminLiuPenrose requested a review from a team as a code owner April 3, 2020 03:00
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Apr 3, 2020
@the-knights-who-say-ni

the-knights-who-say-ni commented Apr 3, 2020

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@BenjaminLiuPenrose

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting review label Apr 3, 2020
@BenjaminLiuPenrose BenjaminLiuPenrose changed the title Fix issue in cython project: Cython files don't compile on Mingw-w64 64-bit bpo-40167 Fix issue in cython project: Cython files don't compile on Mingw-w64 64-bit Apr 3, 2020
@BenjaminLiuPenrose
skip news
866dbe9
@BenjaminLiuPenrose

BenjaminLiuPenrose commented Apr 4, 2020

Copy link
Copy Markdown
Author

Hi, I already signed CLA with my github account
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@csabella csabella removed the CLA not signed label May 25, 2020
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 25, 2020
taleinat
taleinat suggested changes Sep 26, 2020
View reviewed changes
Comment thread Misc/NEWS.d/next/Windows/2020-01-24-09-15-41.bpo-8901.hVnhGO.rst
Comment on lines +2 to +3
Add Mingw-w64 64-bit windows machine, fix issue
in https://bugs.python.org/issue40167

@taleinat taleinat Sep 26, 2020

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to create a new NEWS entry file rather than adding this to an existing one. Use blurb-it or blurb.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread PC/pyconfig.h


/* Compiler specific defines */
#ifdef __MINGW32__

@taleinat taleinat Sep 26, 2020

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment explaining why and when this is needed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting review labels Sep 26, 2020
@bedevere-bot

bedevere-bot commented Sep 26, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel iritkatriel changed the title bpo-40167 Fix issue in cython project: Cython files don't compile on Mingw-w64 64-bit bpo-35037 Fix issue in cython project: Cython files don't compile on Mingw-w64 64-bit Oct 20, 2021
@iritkatriel

iritkatriel commented Oct 20, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Closed bpo-40167 as a duplicate of an older bpo-35037 which has more info. Please update the PR as requested by @taleinat
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@imba-tjd imba-tjd mentioned this pull request Jan 27, 2022
[BUG] Problems when building cython with mingw64 and msc_ver == '1800' pypa/setuptools#2898
Closed
1 task done
@jimboyeah

jimboyeah commented Apr 7, 2022

Copy link
Copy Markdown

You should specify -DMS_WIN64 for g++ to using MinGW-64 on Windows.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@jimboyeah

jimboyeah commented Apr 7, 2022

Copy link
Copy Markdown

You should specify -DMS_WIN64 for g++ to using MinGW-64 on Windows.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@taleinat

taleinat commented Apr 7, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The original author hasn't picked this up again since my comments 1.5 years ago. I think we can consider them no longer interested.

Is anyone else interested in bringing this to completion? @jimboyeah?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ezio-melotti ezio-melotti removed the CLA signed label Jul 13, 2022
@scoder scoder mentioned this pull request Aug 5, 2022
PYLONG_BITS_IN_DIGIT differs between MinGW and MSVC #79218
Open
@GalaxySnail GalaxySnail mentioned this pull request Dec 9, 2022
gh-79218: Define MS_WIN64 macro for Mingw-w64 64bit on Windows #100137
Merged
@rgommers

rgommers commented Feb 15, 2023

Copy link
Copy Markdown
Contributor

This PR can be closed, it was superceded by gh-100137 which was merged 2 months ago.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arhadthedev

arhadthedev commented Feb 15, 2023

Copy link
Copy Markdown
Member

@rgommers Thank you for pointing the duplicate out! Closing.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arhadthedev arhadthedev closed this Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@taleinat taleinat taleinat requested changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@BenjaminLiuPenrose @the-knights-who-say-ni @bedevere-bot @iritkatriel @jimboyeah @taleinat @rgommers @arhadthedev @csabella @ezio-melotti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.