GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-79218: Define `MS_WIN64` macro for Mingw-w64 64bit on Windows by GalaxySnail · Pull Request #100137 · python/cpython

Conversation

@GalaxySnail

@GalaxySnail GalaxySnail commented Dec 9, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Replace gh-19326.

Msys2 has fixed it for some time:

  • msys2-contrib@43133b5
  • v3.10.8...msys2-contrib:cpython-mingw:mingw-v3.10.8

Co-authored-by: Алексей [email protected]
Co-authored-by: Christoph Reiter [email protected]

  • Issue: PYLONG_BITS_IN_DIGIT differs between MinGW and MSVC #79218

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
GalaxySnail added 2 commits December 9, 2022 22:32
@GalaxySnail
define MS_WIN64 for 64bit mingw-w64
a49192a
@GalaxySnail
add NEWS
ae6ab60
@GalaxySnail
GalaxySnail requested a review from a team as a code owner December 9, 2022 15:08
@bedevere-bot bedevere-bot mentioned this pull request Dec 9, 2022
PYLONG_BITS_IN_DIGIT differs between MinGW and MSVC #79218
Open
@netlify

netlify Bot commented Dec 9, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

✅ Deploy Preview for python-cpython-preview canceled.

Name Link
🔨 Latest commit ae312e4
🔍 Latest deploy log https://app.netlify.com/sites/python-cpython-preview/deploys/639355159341490008c61bda
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot added the awaiting review label Dec 9, 2022
@ghost

ghost commented Dec 9, 2022 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

zooba
zooba reviewed Dec 9, 2022
View reviewed changes

@zooba zooba left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be simplified down to only define MS_WIN64, as the other variables are always defined unconditionally in this file.

(If Mingw isn't using the MSBuild files, then this change needs to go into the autoconf files for the generated pyconfig.h. This header file is only used by the PCbuild build files, not via make.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread PC/pyconfig.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread PC/pyconfig.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

@GalaxySnail
only define MS_WIN64
ae312e4
@GalaxySnail

GalaxySnail commented Dec 9, 2022

Copy link
Copy Markdown
Contributor Author

This can be simplified down to only define MS_WIN64, as the other variables are always defined unconditionally in this file.

Fixed.

(If Mingw isn't using the MSBuild files, then this change needs to go into the autoconf files for the generated pyconfig.h. This header file is only used by the PCbuild build files, not via make.)

If cpython is compiled by MSBuild and cython extension is compiled by mingw-w64 (which is the most common case, I think), it works. If someone (for example, msys2) wants to compile cpython itself by mingw-w64, many patches will be required anyway.

zooba reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

zooba
zooba approved these changes Dec 9, 2022
View reviewed changes

@zooba zooba left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge once CI passes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

GalaxySnail reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Dec 9, 2022
@zooba
zooba merged commit 158b8a0 into python:main Dec 12, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 12, 2022
carljm added a commit to carljm/cpython that referenced this pull request Dec 14, 2022
@carljm
Merge branch 'main' into typedocs
53d33a1
* main: (103 commits)
  pythongh-100248: Add missing `ssl_shutdown_timeout` parameter in `asyncio` docs (python#100249)
  Assorted minor fixes for specialization stats. (pythonGH-100219)
  pythongh-100176: venv: Remove redundant compat code for Python <= 3.2 (python#100177)
  pythonGH-100222: Redefine _Py_CODEUNIT as a union to clarify structure of code unit. (pythonGH-100223)
  pythongh-99955: undef ERROR and SUCCESS before redefining (fixes sanitizer warning) (python#100215)
  pythonGH-100206: use versionadded for the addition of sysconfig.get_default_scheme (python#100207)
  pythongh-81057: Move _Py_RefTotal to the "Ignored Globals" List (pythongh-100203)
  pythongh-81057: Move Signal-Related Globals to _PyRuntimeState (pythongh-100085)
  pythongh-81057: Move faulthandler Globals to _PyRuntimeState (pythongh-100152)
  pythongh-81057: Move tracemalloc Globals to _PyRuntimeState (pythongh-100151)
  pythonGH-100143: Improve collecting pystats for parts of runs (pythonGH-100144)
  pythongh-99955: standardize return values of functions in compiler's code-gen (python#100010)
  pythongh-79218: Define `MS_WIN64` macro for Mingw-w64 64bit on Windows (pythonGH-100137)
  Fix: typo (Indention) (pythonGH-99904)
  pythongh-96715 Remove redundant NULL check in `profile_trampoline` function (python#96716)
  pythongh-100176: remove incorrect version compatibility check from argument clinic (python#100190)
  clarify the 4300-digit limit on int-str conversion (python#100175)
  pythongh-70393: Clarify mention of "middle" scope (python#98839)
  pythongh-99688: Fix outdated tests in test_unary (python#99712)
  pythongh-100174: [Enum] Correct PowersOfThree example. (pythonGH-100178)
  ...
@GalaxySnail GalaxySnail mentioned this pull request Dec 21, 2022
[ENH] Make MinGW work on Windows cython/cython#4470
Open
This was referenced Feb 15, 2023
Python dependency refactor mesonbuild/meson#11392
Merged
bpo-35037 Fix issue in cython project: Cython files don't compile on Mingw-w64 64-bit #19326
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@GalaxySnail @zooba @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.