GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||
GeezerVison is showing github.com — bpo-1635741: Port _lzma module to multiphase initialization by corona10 · Pull Request #19382 · python/cpython Conversation
|
|
I ran the several leak test also for subinterp. class SubinterpThreadingTests(unittest.TestCase): def test_lzma_subinterp(self): code = textwrap.dedent(r""" import os from lzma import LZMACompressor, LZMADecompressor, LZMAError lzc = LZMACompressor() lzd = LZMADecompressor() def noop(*args): pass os.register_at_fork(after_in_child=noop) """) ret = support.run_in_subinterp(code) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@shihai1991 Can you please take a look? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
7558ffb to
525190c
Compare
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
thanks, LGTM.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@vstinner Please take a look :) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
with patch (https://bugs.python.org/issue40149#msg365560) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
498affa to
c556f77
Compare
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just two minor coding style remarks.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.