GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-1635741: Port _lzma module to multiphase initialization by corona10 · Pull Request #19382 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Apr 5, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue1635741

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 5, 2020
@bedevere-bot bedevere-bot added the awaiting review label Apr 5, 2020
@corona10

corona10 commented Apr 5, 2020

Copy link
Copy Markdown
Member Author

I ran the several leak test also for subinterp.
No leak was found on this change.

class SubinterpThreadingTests(unittest.TestCase):
    def test_lzma_subinterp(self):
        code = textwrap.dedent(r"""
            import os
            from lzma import LZMACompressor, LZMADecompressor, LZMAError
            lzc = LZMACompressor()
            lzd = LZMADecompressor()
            def noop(*args):
                pass

            os.register_at_fork(after_in_child=noop)
        """)
        ret = support.run_in_subinterp(code)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@corona10

corona10 commented Apr 5, 2020

Copy link
Copy Markdown
Member Author

@shihai1991 Can you please take a look?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@corona10
corona10 requested a review from vstinner April 5, 2020 04:44
shihai1991
shihai1991 reviewed Apr 5, 2020
View reviewed changes
Comment thread Modules/_lzmamodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Modules/_lzmamodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

@corona10
corona10 force-pushed the bpo-1635741-lzma branch 3 times, most recently from 7558ffb to 525190c Compare April 5, 2020 13:03
shihai1991
shihai1991 approved these changes Apr 5, 2020
View reviewed changes

@shihai1991 shihai1991 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Apr 5, 2020
@corona10

corona10 commented Apr 5, 2020

Copy link
Copy Markdown
Member Author

@vstinner Please take a look :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@corona10

corona10 commented Apr 6, 2020

Copy link
Copy Markdown
Member Author
./python.exe -m test test_capi -R 3:3
0:00:00 load avg: 1.34 Run tests sequentially
0:00:00 load avg: 1.34 [1/1] test_capi
beginning 6 repetitions
123456
......
test_capi passed in 34.3 sec

== Tests result: SUCCESS ==

1 test OK.

Total duration: 34.3 sec
Tests result: SUCCESS

with patch (https://bugs.python.org/issue40149#msg365560)

./python.exe -m test test_threading -R 3:3
0:00:00 load avg: 1.84 Run tests sequentially
0:00:00 load avg: 1.84 [1/1] test_threading
beginning 6 repetitions
123456
......
test_threading passed in 1 min 11 sec

== Tests result: SUCCESS ==

1 test OK.

Total duration: 1 min 11 sec
Tests result: SUCCESS
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@corona10
bpo-1635741: Port _lzma module to multiphase initialization
c556f77
@corona10
corona10 force-pushed the bpo-1635741-lzma branch from 498affa to c556f77 Compare June 22, 2020 14:38
@corona10 corona10 added the DO-NOT-MERGE label Jun 22, 2020
@corona10
bpo-1635741: Fix memory leak
14ef8fa
@corona10 corona10 removed the DO-NOT-MERGE label Jun 22, 2020
corona10 added 2 commits June 22, 2020 23:47
@corona10
bpo-1635741: Update NEWS.d
3041995
@corona10
bpo-1635741: Apply PEP 7
60d315c
vstinner
vstinner approved these changes Jun 22, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just two minor coding style remarks.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Modules/_lzmamodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Modules/_lzmamodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Modules/_lzmamodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 22, 2020
@corona10
bpo-1635741: Apply Victor's review
f60b591
@corona10
corona10 merged commit 1937edd into python:master Jun 22, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 22, 2020
@corona10
corona10 deleted the bpo-1635741-lzma branch June 22, 2020 15:53
fasih pushed a commit to fasih/cpython that referenced this pull request Jun 29, 2020
@corona10 @fasihahmad
bpo-1635741: Port _lzma module to multiphase initialization (pythonGH…
6b5456b
…-19382)
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Py_Finalize() doesn't clear all Python objects at exit #44470
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@shihai1991 shihai1991 shihai1991 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@corona10 @vstinner @shihai1991 @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.