GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — bpo-40204: Update documentation formatting for Sphinx 3.0 by jakobandersen · Pull Request #19397 · python/cpython Conversation
|
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
|
||
| where *object* is the Python object to be converted and *address* is the | ||
| :c:type:`void\*` argument that was passed to the :c:func:`PyArg_Parse\*` function. | ||
| :c:expr:`void*` argument that was passed to the ``PyArg_Parse*`` functions. |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
:c:func: not just changes the style and adds a link, but it also adds () after the function name. Please add explicit () in all sites where you changed :c:func: to :c:expr: or `` ``.
| :c:expr:`void*` argument that was passed to the ``PyArg_Parse*`` functions. | |
| :c:expr:`void*` argument that was passed to the ``PyArg_Parse*()`` functions. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| \*`) as its argument and should return a "new" Python object, or ``NULL`` if an | ||
| error occurred. | ||
| function is called with *anything* (which should be compatible with | ||
| :c:expr:`void*`)as its argument and should return a "new" Python object, or |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
| :c:expr:`void*`)as its argument and should return a "new" Python object, or | |
| :c:expr:`void*`) as its argument and should return a "new" Python object, or |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| error occurred. | ||
| function is called with *anything* (which should be compatible with | ||
| :c:expr:`void*`)as its argument and should return a "new" Python object, or | ||
| ``NULL`` if an error occurred. |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Seems the tab character is used here. Please replace all tab characters with spaces and check that lines are correctly aligned.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
|
||
| This is a convenience function to raise :exc:`WindowsError`. If called with | ||
| *ierr* of :c:data:`0`, the error code returned by a call to :c:func:`GetLastError` | ||
| *ierr* of :c:expr:`0`, the error code returned by a call to :c:func:`GetLastError` |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I think it is enough to use
| *ierr* of :c:expr:`0`, the error code returned by a call to :c:func:`GetLastError` | |
| *ierr* of ``0``, the error code returned by a call to :c:func:`GetLastError` |
as for all literals.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
https://build.opensuse.org/request/show/812851 by user mcepl + dimstar_suse - add requires python3-base on libpython subpackage (bsc#1167008) - build against Sphinx 2.x until python is compatible with Sphinx 3.x (see gh#python/cpython#19397, bpo#40204) - Fix build with SQLite 3.32 (bpo#40783) add bpo40784-Fix-sqlite3-deterministic-test.patch
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
The problem of this PR is that :c:expr: is not supported by Sphinx 2, and so this PR drops Sphinx 2 support. Since Sphinx 3 is not widely adopted yet, I proposed a different approach which keeps Sphinx 2 support, but adds Sphinx 3 support, see: https://bugs.python.org/issue40204 Sphinx 2+3 support can be added to stable branches, it's not a backward incompatible change. But my changes require Sphinx 3.2 which adds a new option to opt-in for Sphinx 2 syntax for the C domain.
This PR contains a few relevant changes which are compatible with Sphinx 2. If you want, please try to extract them and write a new PR.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks for your contribution! But your PR couldn't be merged. If you want, please try to extract your changes which are relevant and compatible with Sphinx 2. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.