GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-35212: fix col_offset in f-strings by matanagasauce · Pull Request #19398 · python/cpython

Conversation

@matanagasauce

@matanagasauce matanagasauce commented Apr 6, 2020 •
edited by taleinat
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

https://bugs.python.org/issue35212

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@matanagasauce
bpo-35212: fix col_offset in f-strings
8540465
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 6, 2020
@bedevere-bot bedevere-bot added the awaiting review label Apr 6, 2020
matanagasauce and others added 2 commits April 7, 2020 13:59
@matanagasauce
make test_fstring accord with fixed col_offsets
0b1cba0
@blurb-it
📜🤖 Added by blurb_it.
6c3dce2
@pablogsal

pablogsal commented Aug 31, 2020

Copy link
Copy Markdown
Member

Hi @yangyangxcf. Unfortunately, the ast.c module has changed recently and all the functionality has been ported to some new files under the Parser directory. Could you update your PR for the new layout? If you don't have time, I could do it for you if you wish.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@taleinat

taleinat commented Sep 26, 2020

Copy link
Copy Markdown
Contributor

Ping, @yangyangxcf, @pablogsal?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal

pablogsal commented Sep 26, 2020

Copy link
Copy Markdown
Member

Ping, @yangyangxcf, @pablogsal?

This PR still needs to be rebased as per #19398 (comment). As I mentioned, I am fine to take it over if @yangyangxcf is ok with that

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@taleinat

taleinat commented Sep 27, 2020

Copy link
Copy Markdown
Contributor

Let's give this another couple of weeks then, @pablogsal?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@s-cork s-cork mentioned this pull request Jun 29, 2021
incorrect reporting of fstring col_offsets skulpt/skulpt-parser#75
Closed
@DanielNoord

DanielNoord commented Mar 16, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

I believe this was fixed by #27729.

The reported issues seem similar to what is fixed there. Note that on Python 3.10 this now works as expected:

>>> ast.parse("f'{a}'").body[0].value.values[0].value.col_offset
3
>>> ast.parse("f'{a:b}'").body[0].value.values[0].value.col_offset
3

The other issue in the original report is resolved as well.

Edit: @ericvsmith Gentle ping since you closed the bpo and might want to close this PR as well 😄

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ericvsmith

ericvsmith commented Mar 16, 2022

Copy link
Copy Markdown
Member

@DanielNoord :Thanks for the reminder!

DanielNoord reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ericvsmith ericvsmith closed this Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@matanagasauce @pablogsal @taleinat @DanielNoord @ericvsmith @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.