GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||
GeezerVison is showing github.com — bpo-35212: fix col_offset in f-strings by matanagasauce · Pull Request #19398 · python/cpython Conversation
|
|
Hi @yangyangxcf. Unfortunately, the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Ping, @yangyangxcf, @pablogsal? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
This PR still needs to be rebased as per #19398 (comment). As I mentioned, I am fine to take it over if @yangyangxcf is ok with that |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Let's give this another couple of weeks then, @pablogsal? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
I believe this was fixed by #27729. The reported issues seem similar to what is fixed there. Note that on Python 3.10 this now works as expected: >>> ast.parse("f'{a}'").body[0].value.values[0].value.col_offset 3 >>> ast.parse("f'{a:b}'").body[0].value.values[0].value.col_offset 3 The other issue in the original report is resolved as well. Edit: @ericvsmith Gentle ping since you closed the bpo and might want to close this PR as well 😄 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@DanielNoord :Thanks for the reminder! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.