GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-44885: Correct the ast locations of f-strings with format specs and repeated expressions by pablogsal · Pull Request #27729 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Aug 11, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue44885

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
pablogsal added 2 commits August 11, 2021 15:56
@pablogsal
bpo-44885: Correct the ast locations of f-strings with format specs a…
33ef6ad 
…nd repeated expressions
@pablogsal
Update frozen importlib
33509c0
@pablogsal
pablogsal requested a review from lysnikolaou as a code owner August 11, 2021 15:39
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 11, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Aug 11, 2021
@pablogsal
pablogsal force-pushed the bpo-44885 branch 3 times, most recently from 4bfd0dc to 528cb29 Compare August 11, 2021 15:53
@pablogsal
pablogsal requested review from ammaraskar and isidentical August 11, 2021 15:55
@pablogsal
pablogsal force-pushed the bpo-44885 branch from 528cb29 to 33ef6ad Compare August 11, 2021 15:56
isidentical
isidentical reviewed Aug 12, 2021
View reviewed changes
Comment thread Parser/string_parser.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal @isidentical
Update Parser/string_parser.c
2059d9e 
Co-authored-by: Batuhan Taskaya <[email protected]>
isidentical
isidentical approved these changes Aug 12, 2021
View reviewed changes

@isidentical isidentical left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Aug 12, 2021
ammaraskar
ammaraskar approved these changes Aug 12, 2021
View reviewed changes
@pablogsal
pablogsal merged commit 8e832fb into python:main Aug 12, 2021
@pablogsal
pablogsal deleted the bpo-44885 branch August 12, 2021 16:13
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 12, 2021
@pablogsal pablogsal added needs backport to 3.9 labels Aug 12, 2021
@miss-islington

miss-islington commented Aug 12, 2021

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Aug 12, 2021

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Aug 12, 2021

Copy link
Copy Markdown
Contributor

Sorry, @pablogsal, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8e832fb2a2cb54d7262148b6ec15563dffb48d63 3.9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned pablogsal Aug 12, 2021
@miss-islington

miss-islington commented Aug 12, 2021

Copy link
Copy Markdown
Contributor

Sorry @pablogsal, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 8e832fb2a2cb54d7262148b6ec15563dffb48d63 3.10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal pablogsal mentioned this pull request Aug 12, 2021
[3.10] bpo-44885: Correct the ast locations of f-strings with format … #27743
Merged
pablogsal added a commit to pablogsal/cpython that referenced this pull request Aug 12, 2021
@pablogsal
[3.10] bpo-44885: Correct the ast locations of f-strings with format …
af8b020 
…specs and repeated expressions (pythonGH-27729).

(cherry picked from commit 8e832fb)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
@bedevere-bot

bedevere-bot commented Aug 12, 2021

Copy link
Copy Markdown

GH-27743 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed needs backport to 3.10 labels Aug 12, 2021
@bedevere-bot

bedevere-bot commented Aug 12, 2021

Copy link
Copy Markdown

GH-27744 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal added a commit to pablogsal/cpython that referenced this pull request Aug 12, 2021
@pablogsal
[3.9] bpo-44885: Correct the ast locations of f-strings with format s…
b01000e 
…pecs and repeated expressions (pythonGH-27729).

(cherry picked from commit 8e832fb)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
pablogsal added a commit that referenced this pull request Aug 12, 2021
@pablogsal
[3.10] bpo-44885: Correct the ast locations of f-strings with format …
c28c2e1 
…specs and repeated expressions (GH-27729) (GH-27743)

(cherry picked from commit 8e832fb)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
pablogsal added a commit that referenced this pull request Aug 12, 2021
@pablogsal
[3.9] bpo-44885: Correct the ast locations of f-strings with format s…
4b86c9c 
…pecs and repeated expressions (GH-27729) (GH-27744)

(cherry picked from commit 8e832fb)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
@DanielNoord DanielNoord mentioned this pull request Mar 16, 2022
bpo-35212: fix col_offset in f-strings #19398
Closed
@wookayin wookayin mentioned this pull request Sep 18, 2022
Expressions with format specifiers in f-strings have incorrect offsets numirias/semshi#31
Open
@alexmojaki alexmojaki mentioned this pull request Oct 3, 2022
ast: Different FormattedValue expressions have same col_offset information #81639
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ammaraskar ammaraskar ammaraskar approved these changes
@isidentical isidentical isidentical approved these changes
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@pablogsal pablogsal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@pablogsal @miss-islington @bedevere-bot @ammaraskar @isidentical @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.