GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40237: Fix the coverage gate in travis CI by shihai1991 · Pull Request #19460 · python/cpython

Conversation

@shihai1991

@shihai1991 shihai1991 commented Apr 10, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue40237

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@shihai1991
Fix the coverage gate in travis CI
1a1c634
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 10, 2020
@bedevere-bot bedevere-bot added the awaiting review label Apr 10, 2020
@shihai1991 shihai1991 changed the title WIP: Fix the coverage gate in travis CI bpo-40237: Fix the coverage gate in travis CI Apr 10, 2020
@shihai1991
Fix the coverage gate in travis CI
dd70c44
@shihai1991 shihai1991 changed the title bpo-40237: Fix the coverage gate in travis CI [WIP] bpo-40237: Fix the coverage gate in travis CI Apr 11, 2020
shihai1991 added 2 commits April 11, 2020 18:53
@shihai1991
update params of make coverage
a2624d8
@shihai1991
resolve confilicts
1610855
@shihai1991 shihai1991 changed the title [WIP] bpo-40237: Fix the coverage gate in travis CI bpo-40237: Fix the coverage gate in travis CI Apr 12, 2020
@shihai1991

shihai1991 commented Apr 12, 2020

Copy link
Copy Markdown
Member Author

@vstinner Hi，victor. Do you have time to take a look?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@csabella
csabella requested review from benjaminp and vstinner April 16, 2020 14:58
@ammaraskar

ammaraskar commented Oct 6, 2021

Copy link
Copy Markdown
Member

With #25679 turning down coverage builds, this is no longer necessary. Thank you for the pull request and fix Hai Shi!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ammaraskar ammaraskar closed this Oct 6, 2021
@shihai1991

shihai1991 commented Oct 7, 2021

Copy link
Copy Markdown
Member Author

With #25679 turning down coverage builds, this is no longer necessary. Thank you for the pull request and fix Hai Shi!

Oh, Thanks, Ammar. I forget to close this PR in time.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner
@benjaminp benjaminp Awaiting requested review from benjaminp

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@shihai1991 @ammaraskar @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.